Skip to content

fix crash when query argument is not text #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix crash when query argument is not text #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions redis_fdw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1621,22 +1621,20 @@ redisGetQual(Node *node, TupleDesc tupdesc, char **key, char **value, bool *push

if (IsA(right, Const))
{
StringInfoData buf;

initStringInfo(&buf);
if (((Const *) right)->consttype == TEXTOID) {
/* And get the column and value... */
*key = NameStr(TupleDescAttr(tupdesc, varattno - 1)->attname);
*value = TextDatumGetCString(((Const *) right)->constvalue);

/* And get the column and value... */
*key = NameStr(TupleDescAttr(tupdesc, varattno - 1)->attname);
*value = TextDatumGetCString(((Const *) right)->constvalue);

/*
* We can push down this qual if: - The operatory is TEXTEQ - The
* qual is on the key column
*/
if (op->opfuncid == PROCID_TEXTEQ && strcmp(*key, "key") == 0)
*pushdown = true;
/*
* We can push down this qual if: - The operatory is TEXTEQ - The
* qual is on the key column
*/
if (op->opfuncid == PROCID_TEXTEQ && strcmp(*key, "key") == 0)
*pushdown = true;

return;
return;
}
}
}

Expand Down