Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set standard RADIUS attributes ouside of the RADIUS class #534

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Set standard RADIUS attributes ouside of the RADIUS class #534

merged 3 commits into from
Aug 6, 2018

Commits on Jul 9, 2018

  1. Remove standard RADIUS attributes 

    Radius Attributes are currently not used in a common/standard way by pfSense Authentication components (currently OpenVPN, IPsec xAuth and CaptivePortal) when performing an Authentication.
In an attempt to clarify RADIUS PHP code, i suggested in pfsense/pfsense#3640 to standardize the way attributes are used, but outside of the RADIUS class, in auth.inc. This would make normalization easier, and also make the code more clear (i am not sure that using functions like getNasIp() to  retrieve arguments is a best practice. Shouldn't arguments be used instead)?
    @Augustin-FL
    Augustin-FL committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    1e6abf3 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. remove PutStandardAttributes() called twice in accounting request

    @Augustin-FL
    Augustin-FL committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    98d6df7 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. bump PORTREVISION (force rebuild)

    @Augustin-FL
    Augustin-FL authored Jul 16, 2018
    Configuration menu
    Copy the full SHA
    e58a61c View commit details
    Browse the repository at this point in the history