Support graphite backend for telegraf in config-gui #507
Conversation
|
added the requested validation and raised PORTVERSION |
| } else | ||
| { | ||
| $cfg .= "\ttimeout = 2\n"; | ||
| } |
There was a problem hiding this comment.
Please adjust style moving { to the same line of if or else statements
There was a problem hiding this comment.
I have the same comment that @rbgarga had about the braces. Please use K&R, BSD KNF variant style, even for simple statements, to keep them consistent and easy to read, and be careful to use matching and proper indentation.
|
adjusted braces as requested. please merge. |
|
any update? |
| @@ -103,6 +103,20 @@ EOD; | |||
| $cfg .= "\toverwrite_template = false\n"; | |||
| $cfg .= "\ttemplate_name = \"telegraf\"\n"; | |||
| $cfg .= "\turls = [\"" . $telegraf_conf['elasticsearch_server'] . "\"]\n"; | |||
| } else if ((is_array($telegraf_conf['telegraf_output']) && in_array("graphite", $telegraf_conf['telegraf_output'])) || $telegraf_conf['telegraf_output'] == "graphite") { | |||
| $cfg .= "[[outputs.graphite]]\n"; | |||
| $cfg .= "\tservers = [\"" . $telegraf_conf['graphite_server'] . "\"]\n"; | |||
There was a problem hiding this comment.
Would this not still be a problem if they failed to enter a server name? Or would graphite ignore that since it would be empty ([""])? If graphite will ignore the empty server rather than fail, it may be OK as-is.
There was a problem hiding this comment.
I'm not deep into php development. I've aligned my proposal to the existing options.
It will behave the same as an empty inluxdb- server or an empty elastic-server server.
There was a problem hiding this comment.
There was a problem hiding this comment.
So I think this can be considered resolved? Is there anything else left to do?
|
Is there any progress on this? I would really like to use this, too. |
|
What's the problem here? |
|
This PR is now hanging for 3 months. If possible I'd like to get a response. |
|
Is it possible to make this available in the package repository for 2.4.3-RELEASE-p1? |
Changes since 1.1.0: v1.3.0 This release contains some features and enhancements + upgrades all dependencies. - feat: Allow to set reporter on issue create by @ankitpokhrel in #539 - feat: Use single char ellipsis instead of triple dot by @ankitpokhrel in #540 - ehc: Make assignee operation atomic on create by @ankitpokhrel in #531 - ehc: Auto fallback to plain output on notty by @ankitpokhrel in #538 - ehc: Add warning for invalid custom field by @ankitpokhrel in #528 (Original work by @martinpovolny on #525) - fix(build): Invalid commit hash in docker image by @ankitpokhrel in #535 - dep: Upgrade all packages by @ankitpokhrel in #532 - dep: Upgrade golang to v1.19 by @ankitpokhrel in #534 - ci: Upgrade golangci-lint to v1.50.1 by @ankitpokhrel in #536 Full Changelog: ankitpokhrel/jira-cli@v1.2.0...v1.3.0 v1.2.0 This release adds support for Jira v9, a serverinfo command to quickly check your Jira server build info, lets you set resolution, assignee and comment on issue move, and many more. - feat: Add serverinfo command by @ankitpokhrel in #440 - feat: Support for Jira v9 by @ankitpokhrel in #447 - feat: Allow to set start datetime on worklog add by @ankitpokhrel in #453 - feat: Make date time input in worklog flexible by @ankitpokhrel in #465 - feat: Add support for project datatype in custom fields by @oveaurs in #482 - feat: Add weblink to issue (#446) by @Syd7 in #483 - feat: Resolution, assignee & comment on issue move by @ankitpokhrel in #492 - feat: Filter issues by the absence of label(s) by @martinpovolny in #505 - feat: Add labels to the issue listing by @martinpovolny in #506 - feat: Allow setting of fixed columns in the list of issues, epics and sprints by @martinpovolny in #509 - fix: Option to show issues from all projects in sprint list by @ankitpokhrel in #475 - fix: Discrepancy in --insecure flag by @ankitpokhrel in #507 - fix: Make board selection optional by @ankitpokhrel in #502 - fix: Improve support for pager by @ankitpokhrel in #503 - fix: Respect editor env vars in Windows by @ankitpokhrel in #524 - ci: Multi-arch docker image by @ankitpokhrel in #508 - doc: Add link to project in help by @ankitpokhrel in #456 - doc: Add Nix package by @bryanasdev000 in #458 - doc: Update help for completion cmd by @ankitpokhrel in #491 - doc: Add scoop installation process by @alkuzad in #497 - @bryanasdev000 made their first contribution in #458 - @oveaurs made their first contribution in #482 - @Syd7 made their first contribution in #483 - @alkuzad made their first contribution in #497 - @martinpovolny made their first contribution in #505 Full Changelog: ankitpokhrel/jira-cli@v1.1.0...v1.2.0
As telegraf supports graphite as backend pfsense should support configuration too.