pfSense-pkg-suricata: Delete rotated eve.json log files
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The automatic log removal under `suricata_check_dir_size_limit` does not clean-up the ève.json.*` log files properly. This can lead to a situation where the other rotated logs are cleared but the overall directory size can still grow beyond the hard limit. For example, if `eve.json` log retention is set to more than a few days and with `flow` logging enabled: there you can end up with dozens of `32MB` files that are not cleared in time. With this change, that shouldn't happen anymore.
|
@johannrichard : would you consider also including the code in the patch a user submitted on the Redmine bug site for pfSense here: https://redmine.pfsense.org/issues/7756#change-33404? He included a nice patch that makes the log cleanup code much smarter, and it also corrects a few oversights. I was just thought it would be efficient to roll all the log cleanup fixes into a single patch. Thanks, |
|
I'm fine with the log cleanup implementation in #389 which is indeed much more comprehensive! I therefore close this request. Thanks, @opoplawski. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic log removal under
suricata_check_dir_size_limitcurrently does not clean-up theeve.json.*log. This can lead to a situation where the other rotated logs are cleared but the overall directory size can still grow beyond the hard limit.For example, if
eve.jsonlog retention is set to more than a few days and withflowlogging enabled: there you can end up with dozens of files that are not cleared in time.With this change, that shouldn't happen anymore.
This change is especially relevant with respect to changes introduced in #383 that result in large
eve.jsonfiles ifflowis enabled.