Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfSense-pkg-net-snmp: Fix services #336

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

dbaio
Copy link
Contributor

@dbaio dbaio commented Apr 2, 2017

  • Service name must not use hyphens to not get conflicted with pfSenseHelpers.js
  • Fix a typo in snmptrapd executable name
  • Bump PORTREVISION

@doktornotor
Copy link
Contributor

doktornotor commented Apr 2, 2017

Not exactly sure since when does hyphen conflict with a piece of JS but it'd seem whole lot better to me to fix that broken piece of JS.

@dbaio
Copy link
Contributor Author

dbaio commented Apr 2, 2017

Maybe since this commit and this one.

It is used in Status / Services page:

<a href="#" id="restartservice-net_snmptrapd" ><i class="fa fa-repeat" title="Restart Service"></i></a>
<a href="#" id="stopservice-net_snmptrapd"><i class="fa fa-stop-circle-o" title="Stop Service"></i></a>
<a href="#" id="restartservice-zabbix_agentd_lts" ><i class="fa fa-repeat" title="Restart Service"></i></a>
<a href="#" id="stopservice-zabbix_agentd_lts"><i class="fa fa-stop-circle-o" title="Stop Service"></i></a>

Status/Services --> Ajax
Status/Services
service-utils.inc --> get_service_control_links

That code can be fixed, yes, but changing the service name is also valid to keep services working even in not updated machines.

@doktornotor
Copy link
Contributor

doktornotor commented Apr 2, 2017

This also breaks (at least)

and in general introducing regressions with similar totally undocumented, arbitrary restrictions suck goats nuts, to put it mildly.

Filed a bug about this: https://redmine.pfsense.org/issues/7445

@dbaio
Copy link
Contributor Author

dbaio commented Apr 2, 2017

There is no harm in changing the service names for this package because it's a new package under testing.
But if you (and @jim-p) don't agree I can withdraw that commit and let just the typo part in the executable name.

And very nice that you opened that bug on redmine, thank you.

@jim-p
Copy link
Contributor

jim-p commented Apr 3, 2017

It's better not to mix changes in PRs anyhow. The typo fix should be separate.

I'd also prefer to see that service name limitation fixed, if possible, rather than rename the service.

@dbaio
Copy link
Contributor Author

dbaio commented Apr 3, 2017

ok @jim-p, done.

@doktornotor
Copy link
Contributor

Should be fixed with pfsense/pfsense@21a8edd so this one shouldn't be needed any more.

Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is now just the typo fix, so it's OK

@netgate-git-updates netgate-git-updates merged commit 417bb2f into pfsense:devel Apr 3, 2017
@dbaio dbaio deleted the net-snmpd branch April 3, 2017 16:57
netgate-git-updates pushed a commit that referenced this pull request Apr 19, 2020
- set update instruction notes on pkg-message

ChangeLog v1.2.0:
    bumped minimum supported Python version to 2.4
    implemented support for property diffs (Tigris #383)
    allow user-configurable cvsgraph display (Tigris #336)
    allow rNNNN syntax for Subversion revision numbers (Tigris #441)
    display revision numbers in CVS tag/branch selector (Tigris #546)
    allow roots to have optional context (#58)
    use a more secure temporary file generator (#159)
    fix problems with make-database and special characters (#141, #182)
    fix bogus default ci_when value in cvsdb (#200)
    standalone query interface removed (#206)
    GUI support (--gui) removed from standalone.py

ChangeLog v1.2.1:
    security fix: escape subdir lastmod file name

PR:		245728
Submitted by:	Yasuhito FUTATSUKI
netgate-git-updates pushed a commit that referenced this pull request Jul 5, 2022
Changes since 0.3.0:

We reached v1.0.0

- fix!: Replace limit flag with paginate by @ankitpokhrel in #359
- fix!: Append components on edit instead of overriding by @ankitpokhrel in #368
- feat!: Append label to an issue, show labels at issue list view by @stchar in #300
- refactor!: Move boards and project list to subcommand by @ankitpokhrel in #314

- feat: Support custom fields on issue create by @ankitpokhrel in #319
- feat: Add support to read from .netrc by @adolsalamanca in #329
- feat: Add support for OS keyrings/-chains by @boyvanamstel in #348
- feat: Support auth with personal access tokens by @marek-veber / @ankitpokhrel in #327
- feat: Allow to set fixVersions on issue creation by @ankitpokhrel in #276
- feat: Allow insecure TLS by @ankitpokhrel in #305
- feat: Add --no-browser option to open cmd by @ankitpokhrel in #308
- feat: Add search option for boards on jira init by @ankitpokhrel in #322
- feat: Add issues unlink command by @sushilkg in #347
- feat: Support refresh for issues list by @GZLiew in #325
- feat: Ability to delete issue by @ankitpokhrel in #336
- feat: Allow to set custom fields on epic create by @ankitpokhrel in #364
- feat: Allow to edit release-info/fixVersions by @ankitpokhrel in #365
- feat: Allow removing labels on edit by @ankitpokhrel in #371
- feat: Support creating issues with custom subtask type by @danobi in #372
- feat: Allow removing component on edit by @ankitpokhrel in #374
- feat: Allow removing fixVersions on edit by @ankitpokhrel in #376
- feat: Support custom fields on issue edit by @ankitpokhrel in #377
- feat: Jira init non-interactive by @ankitpokhrel in #381
- feat: Show subtasks in issue view by @ankitpokhrel in #382
- feat: Allow project filter in raw jql by @ankitpokhrel in #395

- fix: Makefile compatiblity with Make 3.81 by @danmichaelo in #252
- fix: Config generation issue by @ankitpokhrel in #275
- fix(cfg): Strip trailing slash on server name by @ankitpokhrel in #295
- fix: Jira client should respect timeout opt by @ankitpokhrel in #304
- fix: Respect GLAMOUR_STYLE env on issue view by @ankitpokhrel in #317
- fix: Get subtask handle from config by @ankitpokhrel in #296
- fix: Jira wiki parser by @ankitpokhrel in #326
- fix: Display correctly columns in list sprint command help by @adolsalamanca in #320
- fix: Panic on empty sub-list by @ankitpokhrel in #330
- fix: Issue with assigning user by @ankitpokhrel in #321
- fix: OOM bug on issue view by @ankitpokhrel in #350
- fix: Assign parent key as is on edit by @ankitpokhrel in #351
- fix: Add additional check for total boards returned by @ankitpokhrel in #360
- fix: Issue with query param in user assignment by @ankitpokhrel in #380
- fix: Subtask clone by @ankitpokhrel in #383
- fix: editing issue with custom field in non interactive mode by @DrudgeRajen in #391

- dep: Upgrade charmbracelet/glamour to 0.5.0 by @ankitpokhrel in #309
- dep: Upgrade rivo/tview to latest by @ankitpokhrel in #310
- dep: Upgrade outdated packages by @ankitpokhrel in #311
- dep: Upgrade cobra to 1.4.0 by @ankitpokhrel in #373

- Use md ext for tmp file to trigger vim syntax by @ElementalWarrior in #318

Full Changelog: ankitpokhrel/jira-cli@v0.3.0...v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants