Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PKCS#11 support. #198

Closed
wants to merge 1 commit into from
Closed

Added PKCS#11 support. #198

wants to merge 1 commit into from

Conversation

skrude61
Copy link
Contributor

Add support for PKCS#11 certificate store (e. g. SafeNet eToken).
Settings can be saved as default (for each server), so only the individual PKCS#11 ID must be filled in before client export.
Only tested with Microsoft Windows client, not with Viscosity.

@jim-p
Copy link
Contributor

jim-p commented Oct 12, 2016

I still see some of the persistent settings code being added here. That all has to be removed before it can be accepted.

@jim-p jim-p closed this Oct 12, 2016
@skrude61
Copy link
Contributor Author

I have no clue what you meant with "I still see some of the persistent settings code being added here".

jim-p
jim-p reviewed Oct 12, 2016
View reviewed changes
security/pfSense-pkg-openvpn-client-export/files/usr/local/www/vpn_openvpn_export.php
@@ -108,6 +108,51 @@
$ras_server[] = $ras_serverent;
}

$a_config =& $config['installedpackages']['openvpnclientexport'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is looking for stored settings, the page to store the settings was removed but not this code.

@skrude61
Copy link
Contributor Author

The settings are now stored on the page itself, separate for each OVPN server, so I do not see the problem.

@jim-p
Copy link
Contributor

jim-p commented Oct 12, 2016

I had asked for the stored settings code to be removed before it could be accepted, however. That is a feature that needs a lot more thought/design work before implementation. The two features (Stored settings and PKCS#11) are distinct and shouldn't be made in the same pull request.

netgate-git-updates pushed a commit that referenced this pull request Oct 16, 2016
@ohauer
- update to 1.4.10
b16c88b 
Broker
  Fix TLS operation with websockets listeners and libwebsockets 2.x. Closes
  #186.
  Don.t disconnect client on HUP before reading the pending data. Closes #7.
  Fix some $SYS messages being incorrectly persisted. Closes #191.
  Support OpenSSL 1.1.0.
  Call fsync after persisting data to ensure it is correctly written. Closes
  #189.
  Fix persistence saving of subscription QoS on big-endian machines.
  Fix will retained flag handling on Windows. Closes #222.
  Broker now displays an error if it is unable to open the log file. Closes
  #234.

Client library
  Support OpenSSL 1.1.0.
  Fixed the C++ library not allowing SOCKS support to be used. Closes #198.
  Fix memory leak when verifying a server certificate with a subjectAltName
  section. Closes #237.

Build
  Don.t attempt to install docs when WITH_DOCS=no. Closes #184.

PR:		213532
Submitted by:	ohauer
Approved by:	maintainer <joe@thrallingpenguin.com>
MFH:		2016Q4
netgate-git-updates pushed a commit that referenced this pull request Oct 18, 2016
@ohauer
MFH: r424079
f1f719b 
- update to 1.4.10

Broker
  Fix TLS operation with websockets listeners and libwebsockets 2.x. Closes
  #186.
  Don.t disconnect client on HUP before reading the pending data. Closes #7.
  Fix some $SYS messages being incorrectly persisted. Closes #191.
  Support OpenSSL 1.1.0.
  Call fsync after persisting data to ensure it is correctly written. Closes
  #189.
  Fix persistence saving of subscription QoS on big-endian machines.
  Fix will retained flag handling on Windows. Closes #222.
  Broker now displays an error if it is unable to open the log file. Closes
  #234.

Client library
  Support OpenSSL 1.1.0.
  Fixed the C++ library not allowing SOCKS support to be used. Closes #198.
  Fix memory leak when verifying a server certificate with a subjectAltName
  section. Closes #237.

Build
  Don.t attempt to install docs when WITH_DOCS=no. Closes #184.

PR:		213532
Submitted by:	ohauer
Approved by:	maintainer <joe@thrallingpenguin.com>

Approved by:	ports-secteam (feld)
@skrude61
Copy link
Contributor Author

skrude61 commented Nov 8, 2016

Jim, you accepted PR #209. Did you change your mind regarding stored settings?

netgate-git-updates pushed a commit that referenced this pull request Dec 2, 2016
@ohauer
MFH: r424079
9131324 
- update to 1.4.10

Broker
  Fix TLS operation with websockets listeners and libwebsockets 2.x. Closes
  #186.
  Don.t disconnect client on HUP before reading the pending data. Closes #7.
  Fix some $SYS messages being incorrectly persisted. Closes #191.
  Support OpenSSL 1.1.0.
  Call fsync after persisting data to ensure it is correctly written. Closes
  #189.
  Fix persistence saving of subscription QoS on big-endian machines.
  Fix will retained flag handling on Windows. Closes #222.
  Broker now displays an error if it is unable to open the log file. Closes
  #234.

Client library
  Support OpenSSL 1.1.0.
  Fixed the C++ library not allowing SOCKS support to be used. Closes #198.
  Fix memory leak when verifying a server certificate with a subjectAltName
  section. Closes #237.

Build
  Don.t attempt to install docs when WITH_DOCS=no. Closes #184.

PR:		213532
Submitted by:	ohauer
Approved by:	maintainer <joe@thrallingpenguin.com>

Approved by:	ports-secteam (feld)
netgate-git-updates pushed a commit that referenced this pull request Jul 15, 2022
@OlivierDuchateau @tcberner
sysutils/upower: update to 0.99.20
c480aed 
Bug fixes:
- Ensure polling is resumed after suspend (#198)
- Bugfixes to state guessing code (#146)
- Stability improvements of automated tests

PR:		265206
netgate-git-updates pushed a commit that referenced this pull request Feb 15, 2023
@cschuber
security/sudo: Update to 1.9.13
8bd6398 
Major changes between sudo 1.9.13 and 1.9.12p2:

 * Fixed a bug running relative commands via sudo when "log_subcmds"
   is enabled.  GitHub issue #194.

 * Fixed a signal handling bug when running sudo commands in a shell
   script.  Signals were not being forwarded to the command when
   the sudo process was not run in its own process group.

 * Fixed a bug in cvtsudoers' LDIF parsing when the file ends without
   a newline and a backslash is the last character of the file.

 * Fixed a potential use-after-free bug with cvtsudoers filtering.
   GitHub issue #198.

 * Added a reminder to the default lecture that the password will
   not echo. This line is only displayed when the pwfeedback option
   is disabled. GitHub issue #195.

 * Fixed potential memory leaks in error paths.  GitHub issues #199,
   #202.

 * Fixed potential NULL dereferences on memory allocation failure.
   GitHub issues #204, #211.

 * Sudo now uses C23-style attributes in function prototypes instead
   of gcc-style attributes if supported.

 * Added a new "list" pseudo-command in sudoers to allow a user to
   list another user's privileges.  Previously, only root or a user
   with the ability to run any command as either root or the target
   user on the current host could use the -U option.  This also
   includes a fix to the log entry when a user lacks permission to
   run "sudo -U otheruser -l command".  Previously, the logs would
   indicate that the user tried to run the actual command, now the
   log entry includes the list operation.

 * JSON logging now escapes control characters if they happen to
   appear in the command or environment.

 * New Albanian translation from translationproject.org.

 * Regular expressions in sudoers or logsrvd.conf may no longer
   contain consecutive repetition operators.  This is implementation-
   specific behavior according to POSIX, but some implementations
   will allocate excessive amounts of memory.  This mainly affects
   the fuzzers.

 * Sudo now builds AIX-style shared libraries and dynamic shared
   objects by default instead of svr4-style. This means that the
   default sudo plugins are now .a (archive) files that contain a
   .so shared object file instead of bare .so files.  This was done
   to improve compatibility with the AIX Freeware ecosystem,
   specifically, the AIX Freeware build of OpenSSL.  Sudo will still
   load svr4-style .so plugins and if a .so file is requested,
   either via sudo.conf or the sudoers file, and only the .a file
   is present, sudo will convert the path from plugin.so to
   plugin.a(plugin.so) when loading it.  This ensures compatibility
   with existing configurations.  To restore the old, pre-1.9.13
   behavior, run configure using the --with-aix-soname=svr4 option.

 * Sudo no longer checks the ownership and mode of the plugins that
   it loads.  Plugins are configured via either the sudo.conf or
   sudoers file which are trusted configuration files.  These checks
   suffered from time-of-check vs. time-of-use race conditions and
   complicate loading plugins that are not simple paths.  Ownership
   and mode checks are still performed when loading the sudo.conf
   and sudoers files, which do not suffer from race conditions.
   The sudo.conf "developer_mode" setting is no longer used.

 * Control characters in sudo log messages and "sudoreplay -l"
   output are now escaped in octal format.  Space characters in the
   command path are also escaped.  Command line arguments that
   contain spaces are surrounded by single quotes and any literal
   single quote or backslash characters are escaped with a backslash.
   This makes it possible to distinguish multiple command line
   arguments from a single argument that contains spaces.

 * Improved support for DragonFly BSD which uses a different struct
   procinfo than either FreeBSD or 4.4BSD.

 * Fixed a compilation error on Linux arm systems running older
   kernels that may not define EM_ARM in linux/elf-em.h.
   GitHub issue #232.

 * Fixed a compilation error when LDFLAGS contains -Wl,--no-undefined.
   Sudo will now link using -Wl,--no-undefined by default if possible.
   GitHub issue #234.

 * Fixed a bug executing a command with a very long argument vector
   when "log_subcmds" or "intercept" is enabled on a system where
   "intercept_type" is set to "trace".  GitHub issue #194.

 * When sudo is configured to run a command in a pseudo-terminal
   but the standard input is not connected to a terminal, the command
   will now be run as a background process.  This works around a
   problem running sudo commands in the background from a shell
   script where changing the terminal to raw mode could interfere
   with the interactive shell that ran the script.
   GitHub issue #237.

 * A missing include file in sudoers is no longer a fatal error
   unless the error_recovery plugin argument has been set to false.

PR:		269563
Submitted by:	cy
Reported by:	cy
Approved by:	garga
MFH:		2023Q1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrude61 @jim-p @netgate-git-updates