POST/PATCH: /firewall/nat/port_forward....bug maybe.

[ch38ter]

1. The "protocol" can NOT be set to "any", or I get "Field protocol must be one of [tcp, udp, tcp/udp, icmp, esp, ah, gre, ipv6, igmp, pim, ospf]".
2. When I use "GET", the "target" may have the value "opt1ip". Isn't is strange without ":" colon ?
3. If the "target" is "opt1ip", the POST/PATCH method not worked. I get "Field target must be a valid IPv4 address, received opt1ip".
4. I tried it with "opt1:ip", not worked either.

Looking forward for reply.

[ch38ter]

pfSense 2.8.0
REST API 2.5.1

[jaredhendrickson13]

These are just additional options that need to be enabled for the protocol and target fields on the backend. I wouldn't consider these bugs since it involves enabling new functionality that wasn't available in earlier versions of the package. Regardless, these can be enabled and added in the next patch.

As clarification for 2, the config value does not include the colon. The colon is used in the API's representation as it is required for the API's reference management to differentiate the interface reference (opt1) from the modifier (ip). The colon is removed when the value is converted to its internal (config) value.

Thanks!

[ch38ter]

Thanks for reply and new commits! Best wishes! @jaredhendrickson13