-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface for register custom ops in torch.ops.ppe
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
requested review from
asi1024,
kmaehashi and
linshokaku
as code owners
December 5, 2023 04:19
emcastillo
changed the title
[WIP] Add interface for register custom ops in
Add interface for register custom ops in Dec 5, 2023
torch.ops.ppe
torch.ops.ppe
emcastillo
force-pushed
the
custom_torch_ops
branch
2 times, most recently
from
December 5, 2023 07:41
bceb2e5
to
f25db7c
Compare
emcastillo
force-pushed
the
custom_torch_ops
branch
from
December 5, 2023 07:55
c1898ce
to
1b26a56
Compare
emcastillo
force-pushed
the
custom_torch_ops
branch
from
December 5, 2023 08:15
4f9a26b
to
1c2f316
Compare
xuzijian629
reviewed
Dec 6, 2023
xuzijian629
reviewed
Dec 6, 2023
I found two small typos. Other code looks good to me! |
Co-authored-by: Joe <joe@preferred.jp>
/test |
xuzijian629
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to avoid decomposition of ops in torch.fx.Graph when using
aot_autograd
backend, or add new operations with autograd support for new execution backends/devices