Merged
Conversation
Contributor
ianlewis
commented
Jan 30, 2026
ianlewis
commented
- Add GitHub Actions workflow for running tests on PRs.
- Greatly refactor Makefile.
- Use specific version of golangci-lint and install locally.
- Format with goimports (remove unnecessary imports), and gci (sort imports).
- Add GitHub Actions workflow for running tests on PRs.
- Greatly refactor Makefile.
- Use specific version of golangci-lint and install locally.
- Format with goimports (remove unnecessary imports), and gci (sort
imports).
Signed-off-by: Ian Lewis <ianlewis@preferred.jp>
ianlewis
force-pushed
the
5-ci-github-actions-workflows
branch
from
88e6cc6 to
509fb16
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a GitHub Actions workflow for automated testing and significantly refactors the Makefile to improve tooling and code formatting practices.
Changes:
- Added GitHub Actions workflow to run tests automatically on pull requests and pushes to main
- Refactored Makefile to install linting/formatting tools locally with pinned versions instead of relying on globally installed tools
- Enhanced formatting capabilities with goimports and gci for import management
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Complete refactor adding local tool installation, pinned versions, enhanced formatting targets, and improved code organization |
| .github/workflows/pull_request.tests.yml | New workflow file that runs automated tests on PRs using the refactored Makefile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ian Lewis <ianlewis@preferred.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.