Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental Numo support #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

experimental Numo support #27

wants to merge 2 commits into from

Conversation

msakai
Copy link
Member

@msakai msakai commented Nov 20, 2018

This PR is based on #26.

The performance is suboptimal due to the conversion via String. This can be improved by copying memory directly using na_get_pointer etc.

@msakai msakai requested a review from colspan November 20, 2018 08:34
@msakai msakai changed the title WIP: experimental Numo support experimental Numo support Nov 20, 2018
@colspan colspan mentioned this pull request May 5, 2019
Open
colspan
colspan reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@colspan colspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちら長い間対応せず申し訳ありませんでした。
一旦確認した旨を報告します。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colspan colspan colspan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msakai @colspan