Code Quality Fixes#76
Open
apermo wants to merge 30 commits into
Open
Conversation
…to action and return value is not used
…hp and template-functions.php
…owance in composer.json
removed unused globals fixed code style fixed phpdoc
…ng in widgets.php
… in entry-share.php
… in entry-share.php
Escape get_permalink(), wp_get_shortlink(), get_the_title(), get_the_author(), get_the_excerpt() and get_the_date() output to prevent potential XSS. Addresses the Copilot review findings on the original PR (pfefferle#71). Co-Authored-By: Claude <noreply@anthropic.com>
Wrap $comment->comment_type in esc_attr() since it is printed into a class attribute. Addresses the Copilot review finding on the original PR (pfefferle#71). Co-Authored-By: Claude <noreply@anthropic.com>
Closed
Author
|
Follow-up commits address the still-valid Copilot review findings from #71:
The Copilot comments on The two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes Code Style, PHPdoc and other code quality fixes.
Pushes with just phpcbf are marked as such.
Besides a few marked places no output should be altered.
This recreates #71, which was closed when my fork left the fork network.
The branch and commits are identical to the original; follow-up commits in
this PR additionally address the still-valid Copilot review findings from
#71 (output escaping in
template-parts/entry-share.phpand the commentclassattribute infunctions.php).Disclosure
Claude assisted with restoring the branch and with the follow-up escaping
commits. I reviewed the changes and take responsibility for them.