fix scrolledToBottom calculation #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2020 12:26
|
@ath92 @mahboubii - thanks for that. I will review thoroughly by the end of the week and merge. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
scrolledToBottomcalculation so that it also works when window is zoomed in/out. Zooming introduces rounding issues, which this PR fixes. This is related to #184.Note that the original issue can easily be reproduced by going to https://virtuoso.dev/stick-to-bottom/ and changing the zoom level of the browser.
This is an alternative fix to #185, which was causing this function to return
trueeven when not scrolled to the bottom for me.I also added the playground files I used to test this change locally. Let me know if they should be removed for this PR to be merged. You can verify locally what this PR does by simply removing the change in
scrolledToBottomEngine.ts; this should break the behaviour in the playground example.