Skip to content

fix: pin feature-ideation.yml reusable workflow to SHA - #113

Closed
don-petry wants to merge 24 commits into
mainfrom
claude/issue-88-20260418-1841
Closed

fix: pin feature-ideation.yml reusable workflow to SHA#113
don-petry wants to merge 24 commits into
mainfrom
claude/issue-88-20260418-1841

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Summary

  • Pins petry-projects/.github/.github/workflows/feature-ideation-reusable.yml from @v1 to its resolved SHA ae9709f4466dec60a5733c9e7487f69dcd004e05 to satisfy the action-pinning compliance policy.
  • Syncs the file with the latest upstream template: adds dry_run workflow_dispatch input, actions: read permission, and sources_file optional comment.

Closes #88

Generated with Claude Code

Pins petry-projects/.github/.github/workflows/feature-ideation-reusable.yml
from @v1 to SHA ae9709f4466dec60a5733c9e7487f69dcd004e05 (v1) to satisfy
the action-pinning compliance policy.

Also syncs the file with the latest upstream template:
- Adds dry_run workflow_dispatch input
- Adds actions: read permission (feed checkpoint support)
- Adds sources_file optional comment
- Aligns comment formatting

Closes #88

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 18, 2026 18:43
@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cb10a0d0-e09e-4ce2-af06-5fc140843165

📥 Commits

Reviewing files that changed from the base of the PR and between 9f32983 and 3b2b404.

📒 Files selected for processing (1)
  • .github/workflows/feature-ideation.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-88-20260418-1841

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Contributor Author

@don-petry — you are the CODEOWNERS for this repository. This PR pins the feature-ideation.yml reusable workflow to SHA ae9709f4466dec60a5733c9e7487f69dcd004e05 (v1) to resolve the action-pinning compliance finding in issue #88. Please review and merge when ready.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Pins the feature-ideation reusable workflow reference to an immutable SHA for compliance, while syncing this workflow file with the latest upstream template.

Changes:

  • Pin petry-projects/.github/.github/workflows/feature-ideation-reusable.yml from @v1 to a specific commit SHA.
  • Add dry_run workflow_dispatch input and pass it through to the reusable workflow.
  • Expand job permissions to include actions: read and update inline documentation/comments (including optional sources_file guidance).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
github-actions Bot requested a review from a team as a code owner May 4, 2026 20:39
@don-petry don-petry closed this May 11, 2026
@don-petry don-petry reopened this May 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

@dev-lead - please fix this PR

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@donpetry-bot

Copy link
Copy Markdown
Contributor

Review — fix requested (cycle 3/3)

The automated review identified the following issues. Please address each one:

Findings to fix

Automated review — NEEDS HUMAN REVIEW

Risk: MEDIUM
Reviewed commit: 3b2b40460ca78492349564444f702990ce2bdcc4
Cascade: triage → deep (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7)

Summary

The code changes are sound and security-positive: SHA pinning removes a mutable tag reference (supply-chain hardening), the added 'actions: read' permission is minimal and read-only, and the 'dry_run' boolean input is correctly typed with a safe false default. All CI gates pass (CodeQL, SonarQube, CodeRabbit green). The sole blocker is a persistent merge conflict with main that has resisted 15+ automated rebase attempts since 2026-05-19 — the PR cannot be merged in its current state and requires manual conflict resolution before approval can stand.

Findings

  • MAJOR: PR is in CONFLICTING/DIRTY state and cannot be merged. Automated rebase has failed 15+ times since 2026-05-19 (most recent failure: 2026-06-01T12:21Z). Manual conflict resolution is required: git fetch origin && git merge origin/main, resolve conflicts, commit, and push.
  • INFO: SHA pin ae9709f4466dec60a5733c9e7487f69dcd004e05 correctly replaces the mutable @v1 tag on the reusable workflow reference, directly addressing supply-chain risk described in issue Compliance: unpinned-actions-feature-ideation.yml #88. The inline '# v1' comment preserves human-readable context.
  • INFO: 'actions: read' permission added to the calling job to support feed-checkpoint functionality in the reusable workflow. This is a minimal read-only scope; no write privilege escalation.
  • INFO: 'dry_run' boolean input added with default: false and correctly typed as boolean — no injection risk. The value is passed as ${{ inputs.dry_run || false }}, which is safe for a boolean type in GitHub Actions.
  • MINOR: Previous automated review (cycle 1, SHA 1c6b7d9) APPROVED this PR. Since that approval, the branch has only received merge-from-main commits with no substantive code changes. The approval remains valid for the code itself; only the merge conflict blocks forward progress.

Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7). Reply if you need a human review.

Additional tasks

  1. Resolve all unresolved review thread comments from other reviewers
  2. Ensure all CI checks pass after your changes
  3. Rebase on the target branch if behind
  4. Do NOT modify files unrelated to the findings above

The review cascade will automatically re-review after new commits are pushed.

@donpetry-bot
donpetry-bot dismissed their stale review June 1, 2026 22:31

Superseded by automated re-review at 3b2b404.

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:19

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: unpinned-actions-feature-ideation.yml

4 participants