-
Notifications
You must be signed in to change notification settings - Fork 1
fix: pin feature-ideation.yml reusable workflow to SHA #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5c0454a
2573671
f4af98f
62a2183
8a05743
1c98cc8
0a6ed97
d491e29
d55e90f
13ff2a2
247dae8
c0e58bf
1747b79
838f588
6b15992
c5d3c3e
5993306
0b0150c
91baf3d
333929a
3415cde
fd86b79
a01ea6c
eb6c8d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -37,7 +37,7 @@ name: Feature Research & Ideation (BMAD Analyst) | |||||
|
|
||||||
| on: | ||||||
| schedule: | ||||||
| - cron: '0 7 * * 5' # Friday 07:00 UTC (3 AM EDT / 2 AM EST) | ||||||
| - cron: '0 7 * * 5' # Friday 07:00 UTC (3 AM EDT / 2 AM EST) | ||||||
| workflow_dispatch: | ||||||
| inputs: | ||||||
| focus_area: | ||||||
|
|
@@ -53,6 +53,11 @@ on: | |||||
| - quick | ||||||
| - standard | ||||||
| - deep | ||||||
| dry_run: | ||||||
| description: 'Skip Discussion mutations and log them to a JSONL artifact instead. Use this on a fork to smoke-test before going live.' | ||||||
| required: false | ||||||
| default: false | ||||||
| type: boolean | ||||||
|
|
||||||
| permissions: {} | ||||||
|
|
||||||
|
|
@@ -75,7 +80,7 @@ jobs: | |||||
| pull-requests: read | ||||||
| discussions: write | ||||||
| id-token: write | ||||||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1 | ||||||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@208ec2d69b75227d375edf8745d84fbac05a76b2 # v1 | ||||||
| with: | ||||||
| # === CUSTOMISE THIS PER REPO — the only required edit === | ||||||
| # Replace this paragraph with a 3-5 sentence description of your project, | ||||||
|
|
@@ -87,5 +92,6 @@ jobs: | |||||
| include A, B, C. Key emerging trends in this space: X, Y, Z." | ||||||
| focus_area: ${{ inputs.focus_area || '' }} | ||||||
| research_depth: ${{ inputs.research_depth || 'standard' }} | ||||||
| dry_run: ${{ inputs.dry_run || false }} | ||||||
|
||||||
| dry_run: ${{ inputs.dry_run || false }} | |
| dry_run: ${{ inputs.dry_run == true || inputs.dry_run == 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header guidance says you “MUST NOT change … the
uses:line”, but this PR legitimately changes it to pin to a SHA for compliance. To avoid future confusion (and reduce the risk of someone reverting the pin), update the guidance to explicitly allow/require SHA pin updates while still forbidding changing the referenced reusable workflow path.