Skip to content

feat: implement issue #172 — Compliance: gitignore_secrets_block - #309

Merged
don-petry merged 10 commits into
mainfrom
dev-lead/issue-172-20260521-1929
May 24, 2026
Merged

feat: implement issue #172 — Compliance: gitignore_secrets_block#309
don-petry merged 10 commits into
mainfrom
dev-lead/issue-172-20260521-1929

Conversation

@don-petry

@don-petry don-petry commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Closes #172

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated configuration to exclude certificate and key files from version control.

Review Change Stack

@don-petry
don-petry requested a review from a team as a code owner May 21, 2026 19:29
Copilot AI review requested due to automatic review settings May 21, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 696bfff4-dbf4-4c36-811c-cd1784f043b9

📥 Commits

Reviewing files that changed from the base of the PR and between 6f464ea and 6e52570.

📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

The .gitignore file is updated to include baseline secret file patterns: *.pem and *.key files are now ignored to prevent accidental commits of private key material to the repository.

Changes

Gitignore secret patterns

Layer / File(s) Summary
Add secret file patterns to gitignore
.gitignore
Two new patterns are added to ignore private key files: *.pem and *.key, preventing accidental commits of sensitive cryptographic material.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #172: Compliance: gitignore_secrets_block — This PR directly addresses the compliance finding by adding the required baseline secret patterns (*.pem, *.key) to .gitignore as specified in the organization standards.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: implementing issue #172 to add secret patterns to .gitignore for compliance.
Linked Issues check ✅ Passed The PR adds *.pem and *.key patterns to .gitignore as required by issue #172, directly addressing the push-protection compliance finding.
Out of Scope Changes check ✅ Passed All changes are scoped to the .gitignore file to address the compliance requirement; no unrelated or extraneous modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-172-20260521-1929

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to exclude sensitive files such as *.pem and *.key. The reviewer recommended adding a header comment to organize these secret patterns and identified a redundant .dev-lead/ entry that should be removed.

Comment thread .gitignore
Comment thread .gitignore
@don-petry

Copy link
Copy Markdown
Collaborator Author

@donpetry-bot please review — compliance fix awaiting auto-review (manually triggered after pr-auto-review.yml is not deployed to this fleet repo)

@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes.

donpetry-bot
donpetry-bot previously approved these changes May 23, 2026

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: ff3a78b38978fc42d4f23e82529c19ff2dc46a20
Review mode: triage-approved (single reviewer)

Summary

Two-line addition to .gitignore adding the *.pem and *.key patterns required by the org push-protection baseline. Triage tier already cleared this as low-risk; this confirmation review agrees — the change is exactly what the linked compliance issue asks for, scope is minimal, and there is nothing to nitpick.

Linked issue analysis

Closes #172 (Compliance: gitignore_secrets_block). The issue specifies that .gitignore is missing baseline secret patterns *.pem and *.key. The PR adds those exact two patterns and nothing else — a direct, in-scope fix.

Findings

  • Diff is exactly 2 additions, 0 deletions, 1 file (.gitignore). No code paths, dependencies, or configuration beyond gitignore are touched.
  • No risk indicators. No auth, secrets, migrations, CI workflow edits, or dependency changes. Adding ignore patterns is a defensive change — it can only prevent future accidental commits of key material, not introduce one.
  • Out-of-scope observation (non-blocking): the file already contains a duplicate .dev-lead/ entry (lines visible in the diff context). This pre-dates the PR and Gemini's bot review flagged it too. Worth a separate housekeeping PR but not a reason to hold this one.
  • No unanswered human-reviewer questions; CodeRabbit reports no actionable comments; SonarQube quality gate passed with 0 new issues.

CI status

All required checks green:

  • CodeQL — Analyze (actions, javascript-typescript, python): SUCCESS
  • CodeQL (rollup): SUCCESS
  • CodeRabbit: SUCCESS
  • SonarQube Cloud quality gate: passed (0 new issues, 0 security hotspots)

Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry
don-petry requested a review from donpetry-bot May 23, 2026 23:46
@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry assigned me as reviewer — starting a fresh review now. Results will appear in a few minutes.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: ff3a78b38978fc42d4f23e82529c19ff2dc46a20
Review mode: triage-approved (single reviewer)

Summary

Manual re-review requested at the same SHA that was already approved. Diff is unchanged: two lines added to .gitignore (*.pem, *.key) — exactly the baseline secret patterns required by linked compliance issue #172. Triage tier classified this as low-risk and this confirmation review agrees.

Linked issue analysis

Closes #172 (Compliance: gitignore_secrets_block). The issue explicitly states that .gitignore is missing baseline secret patterns *.pem and *.key and asks the repo to adopt the org baseline. The PR adds those exact two patterns and nothing else — a direct, in-scope fix that matches the org standard.

Findings

  • Diff is 2 additions, 0 deletions, 1 file (.gitignore). No code paths, dependencies, workflow files, or configuration beyond gitignore are touched.
  • No risk indicators. No auth/secrets/migration/CI edits. Adding ignore patterns is purely defensive — it can only prevent future accidental commits of key material.
  • Pre-existing observation (non-blocking, not introduced by this PR): .gitignore contains a duplicate .dev-lead/ entry on consecutive lines. Gemini's bot review and the previous automated review both flagged this. Worth a separate housekeeping PR but not a reason to block compliance remediation.
  • No unanswered human-reviewer questions; CodeRabbit reports no actionable comments; SonarQube quality gate passed (0 new issues, 0 security hotspots).

CI status

All required checks green at this SHA:

  • CodeQL — Analyze (actions, javascript-typescript, python): SUCCESS
  • CodeQL (rollup): SUCCESS
  • CodeRabbit: SUCCESS
  • SonarQube Cloud quality gate: passed
  • Dev-Lead Agent dispatch: SUCCESS

Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@donpetry-bot
donpetry-bot dismissed their stale review May 23, 2026 23:48

Superseded by automated re-review at ff3a78b.

@don-petry don-petry closed this May 23, 2026
@don-petry don-petry reopened this May 23, 2026
@don-petry don-petry closed this May 23, 2026
@don-petry don-petry reopened this May 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 600af52 into main May 24, 2026
22 of 24 checks passed
@don-petry
don-petry deleted the dev-lead/issue-172-20260521-1929 branch May 24, 2026 00:01
don-petry added a commit that referenced this pull request Aug 4, 2026
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: gitignore_secrets_block

3 participants