feat: implement issue #22 — SonarCloud: reduce cognitive complexity (S3776, CRITICAL) (×3)

[don-petry]

Closes #22

Implemented by dev-lead agent. Please review.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f4122163-1916-4462-b6f0-dbe34fea2ad5

📥 Commits

Reviewing files that changed from the base of the PR and between 8eba91b and ce49842.

📒 Files selected for processing (5)

• scripts/discover.py
• scripts/extract_all.py
• scripts/flatten.py
• tests/conftest.py
• tests/test_scripts.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev-lead/issue-22-20260703-2130

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Refactors the previously SonarCloud-flagged CLI script main() functions (S3776 cognitive complexity) by extracting smaller pure helpers, while adding unit tests to lock in helper behavior and adjusting pytest collection so unit tests always run without requiring a live API key.

Changes:

• Extracted helper functions in scripts/discover.py, scripts/extract_all.py, and scripts/flatten.py to reduce cognitive complexity while preserving behavior.
• Added new unit tests for extracted “pure” helpers (no network / no API key required).
• Updated pytest collection behavior so only the live contract test module is skipped when BROODMINDER_API_KEY is not set.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/test_scripts.py	Adds unit tests for extracted pure helpers (discover/flatten) to lock in behavior offline.
tests/conftest.py	Changes skip logic so only live contract tests are skipped when no API key is present.
scripts/flatten.py	Extracts metric discovery, row-building, per-hive flattening, and output writers to simplify main().
scripts/extract_all.py	Extracts argument parsing, hive selection, per-window processing, and per-hive extraction loop helpers.
scripts/discover.py	Extracts sample-id discovery and endpoint sampling into helpers to flatten main().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[don-petry]

Dev-Lead — review-changes (applied)

Changes committed and pushed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[don-petry]

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-03T22:21:41Z

[don-petry]

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #26
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-04T15:53:57Z

[don-petry]

Dev-Lead Fix CI — applied

PR: #26 | SHA: 766e37326b4f1858f77c86a90ee39e8c2b4b9498
Fix committed and pushed. Waiting for CI.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[don-petry]

Closing this conflicted (DIRTY) PR — main has evolved since it was generated (2026-07-03/07), so a hand-merge would drag stale code over main's newer version. Driving issue #22 keeps its dev-lead label, so this regenerates cleanly against current main (cap-gated, no work lost). (cognitive-complexity S3776; #34 dup already deduped)