Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement issue #258 — Compliance: copilot-instructions-missing-local-dev-commands #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: implement issue #258 — Compliance: copilot-instructions-missing-local-dev-commands #272
Changes from all commits
384878eb8d4d5505a37f1df0e785File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this fenced block is followed top-to-bottom, line 67 leaves the shell in
apps/api, but thesepnpmcommands are root package scripts from/workspace/broodly/package.json;apps/apihas no package manifest or JS/TS scripts. Sincepnpm runruns scripts from a package manifest (https://pnpm.io/cli/run), users copying the documented flow can run the monorepo checks from the wrong directory instead of exercising the workspace; add acd ../..or usepnpm -C ../.. ...before this section.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When contributors follow this new codegen step from
apps/api, thisgo runis resolved in the current module because it has no@versionsuffix (checkedgo help run), butapps/api/go.mod/go.sumdo not requiregithub.com/99designs/gqlgen(rg 99designs apps/api/go.mod apps/api/go.sumreturns no matches). In a normal module-aware Go setup this fails with “no required module provides package” instead of regenerating resolvers, so either add a tracked tool dependency or use a versioned command such as.../gqlgen@<version>.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This newly documented
sqlc generatestep is not runnable in the current API tree:apps/api/sqlc.yamlpoints atinternal/repository/queries/andmigrations/, but I checked the tracked files underapps/apiand neither input directory exists. Contributors who follow the local-dev commands will hit a sqlc input-path error instead of regenerating code, so either add the expected inputs/placeholders or mark this as a planned command until the repository contains them.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For mobile code that reads the Firebase project ID in the Expo JavaScript bundle, copying this example leaves the value unavailable: Expo only inlines
.envvariables with theEXPO_PUBLIC_prefix into client code (see Expo environment variable docs: https://docs.expo.dev/guides/environment-variables/). Since the new instructions mark this variable as used bymobile + api, the mobile example should expose a public, non-secret name such asEXPO_PUBLIC_FIREBASE_PROJECT_IDrather thanFIREBASE_PROJECT_ID.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.