SonarCloud: JavaScript/TypeScript code quality

[don-petry]

SonarCloud: JavaScript/TypeScript code quality

1 open SonarCloud finding(s) in petry-projects/broodly, worst severity MAJOR. Generated by the org SonarCloud Audit.

View in SonarCloud →

Findings

Rule	Count	Representative message
typescript:S4782	1	Consider removing 'undefined' type or '?' specifier, one of them is redundant.

Affected files

• apps/mobile/components/ui/gluestack-ui-provider/index.tsx (1)

Priority

Labeled priority:major — mapped from this bucket's worst SonarCloud severity (MAJOR).

Acceptance

• All findings in this workstream resolved to zero in SonarCloud
• No behavior change; CI green
• Real fixes (no blanket NOSONAR unless a confirmed false positive, noted inline)

---

Idempotent issue — updated automatically each audit run; auto-closed when the finding count reaches zero.

[don-petry]

SonarCloud Audit (2026-08-04): still open — 1 finding(s), worst severity MAJOR.

[don-petry]

Dev-Lead Implementation Plan

Issue: #451 — SonarCloud: JavaScript/TypeScript code quality

Scope

Resolve SonarCloud typescript:S4782 (MAJOR) in apps/mobile/components/ui/gluestack-ui-provider/index.tsx: the style prop is declared optional (?) while its type ViewProps['style'] (StyleProp<ViewStyle>) already includes undefined, making one of the two redundant. Fix is a type-only, behavior-preserving change.

Implementation Checklist

• apps/mobile/components/ui/gluestack-ui-provider/index.tsx: change style?: ViewProps['style'] to style?: NonNullable<ViewProps['style']> so the optional specifier and the type no longer both express undefined.

Tests to Write

• None — pure type-only refactor with zero JS output change (types are erased at compile time). Verification is via tsc --noEmit, ESLint, and the existing Jest suite (Phase 2 TDD exception for behavior-preserving refactors). No provider render test is added because the component transitively loads @gluestack-ui/core (react-aria/react-dom) which the repo's existing smoke tests deliberately avoid.

Test Command

pnpm run test (Jest) plus pnpm run typecheck and pnpm run lint in apps/mobile

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• Fixed typescript:S4782 in apps/mobile/components/ui/gluestack-ui-provider/index.tsx
• Verified typecheck, lint, full Jest suite, dev-lead lint, and prettier all pass

Root Cause & Fix

style?: ViewProps['style'] declared the prop optional (?) while its type ViewProps['style'] resolves to StyleProp<ViewStyle>, which already includes undefined. S4782 flags this redundancy. Fixed by wrapping the type in NonNullable<...> so the optional specifier remains (callers may still omit the prop) but the explicit type no longer restates undefined:

-  style?: ViewProps['style'];
+  style?: NonNullable<ViewProps['style']>;

This is a type-only change — TypeScript types are erased at compile time, so the emitted JavaScript is byte-for-byte identical. The sole call site (App.tsx) passes no style prop and is unaffected.

Test Results

$ tsc --noEmit
TC_EXIT:0

$ eslint .
/apps/mobile/components/ui/heading/index.tsx
  89:40  warning  Unexpected any  (pre-existing, unrelated)
✖ 1 problem (0 errors, 1 warning)
LINT_EXIT:0

$ jest
PASS __tests__/design-tokens.test.ts
PASS __tests__/workspace-resolution.test.ts
PASS __tests__/button-smoke.test.tsx
PASS __tests__/smoke-test.test.tsx
Test Suites: 4 passed, 4 total
Tests:       36 passed, 36 total

$ prettier --check (changed file)
All matched files use Prettier code style!

$ .dev-lead/scripts/dev-lead-lint.sh
[lint] all checks passed

Files Changed

• apps/mobile/components/ui/gluestack-ui-provider/index.tsx: narrowed style prop type to NonNullable<ViewProps['style']> to remove the redundant optional+undefined (S4782).

Notes

• TDD exception (Phase 2): behavior-preserving, type-only refactor with no observable runtime change, so no new test was added. Verification is via tsc, ESLint, and the existing Jest suite. A provider render test was intentionally not added because GluestackUIProvider transitively loads @gluestack-ui/core (react-aria/react-dom), which the repo's existing smoke tests deliberately avoid until react-dom is aligned to React 19.
• The single remaining ESLint warning (heading/index.tsx:89) is pre-existing and out of scope for this issue.