Skip to content

feat: implement issue #385 — Migrate pr-review.yml caller to secrets: inherit (last by-name pr-review caller) #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 3 commits into from
Aug 2, 2026
+5 −9
Merged

feat: implement issue #385 — Migrate pr-review.yml caller to secrets: inherit (last by-name pr-review caller) #394

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b7c72a
feat: implement issue #385 — Migrate pr-review.yml caller to `secrets…
donpetry-bot Jul 21, 2026
09902e4
Merge branch 'main' into dev-lead/issue-385-20260721-1922
don-petry Aug 2, 2026
533b63c
fix(reviews): address review comments [skip ci-relay]
donpetry-bot Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ name: PR Review Agent
# `sonar-project.properties` exemption, which only quieted the gate).
# - `agent_ref: pr-review/stable` pins the agent's own scripts to the same
# channel (#506), so the review logic AND scripts run the known-good version.
# - Secrets are passed explicitly to the reusable workflow.
# `DON_PETRY_BOT_GH_PAT_CLASSIC` is a classic PAT — required for approvals since
# - Secrets are forwarded via `secrets: inherit`, matching every other pr-review
# caller in the org and TalkTerm's own `dev-lead.yml` (#385). The reusable reads
# the inherited org secrets it needs (`DON_PETRY_BOT_GH_PAT_CLASSIC`, falling
# back to `DON_PETRY_BOT_GH_PAT`) — a classic PAT required for approvals since
# fine-grained PATs cannot `addPullRequestReview`.

on:
Expand Down Expand Up @@ -82,10 +84,4 @@ jobs:
pr_url: ${{ inputs.pr_url || '' }}
dry_run: ${{ inputs.dry_run || '' }}
force_review: ${{ inputs.force_review || '' }}
secrets:
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.COPILOT_GITHUB_TOKEN }}
DON_PETRY_BOT_GH_PAT: ${{ secrets.DON_PETRY_BOT_GH_PAT }}
DON_PETRY_BOT_GH_PAT_CLASSIC: ${{ secrets.DON_PETRY_BOT_GH_PAT_CLASSIC }}
GH_PAT: ${{ secrets.GH_PAT }}
secrets: inherit # NOSONAR(githubactions:S7635) first-party trusted reusable
Loading