Skip to content

ci: add required ci.yml workflow - #48

Closed
don-petry wants to merge 1 commit into
mainfrom
claude/issue-20-20260407-1732
Closed

ci: add required ci.yml workflow#48
don-petry wants to merge 1 commit into
mainfrom
claude/issue-20-20260407-1732

Conversation

@don-petry

@don-petry don-petry commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds .github/workflows/ci.yml as a thin caller that delegates to the org-level reusable workflow (ci-reusable.yml@main)
  • Follows the same pattern as claude.yml (and other existing workflows in this repo)
  • Brings the repository into compliance with the missing-ci.yml finding

Closes #20

Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added continuous integration workflow configuration.

Adds the required ci.yml workflow that delegates to the org-level
reusable workflow (ci-reusable.yml@main), following the same pattern
as claude.yml.

Closes #20

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 7, 2026 17:33
@coderabbitai

coderabbitai Bot commented Apr 7, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e04987e-efd0-4390-9eaa-a1ab0a5f0bc3

📥 Commits

Reviewing files that changed from the base of the PR and between 86772fc and b5d3a70.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

Adds a GitHub Actions workflow file .github/workflows/ci.yml that triggers on push and pull_request events to the main branch. The workflow delegates to a centralized reusable workflow from the organization and inherits secrets with specific permissions for read, checks, and pull-requests.

Changes

Cohort / File(s) Summary
GitHub Actions CI Workflow
.github/workflows/ci.yml
Adds new CI workflow configuration that uses the organization's centralized reusable CI workflow via uses: petry-projects/.github/.github/workflows/ci-reusable.yml@main, configured with secrets: inherit and job-level permissions for contents read, checks write, and pull-requests write.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • Compliance: missing-ci.yml #20: Compliance: missing-ci.yml — Directly addresses the compliance finding requiring the missing ci.yml workflow file to be added to the repository.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding a required ci.yml workflow file.
Linked Issues check ✅ Passed The pull request successfully adds the required ci.yml workflow file that delegates to the organization's reusable workflow, directly addressing the missing-ci.yml compliance requirement in issue #20.
Out of Scope Changes check ✅ Passed All changes are directly related to resolving issue #20; only the required ci.yml workflow file was added with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-20-20260407-1732

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Contributor Author

@don-petry — no CODEOWNERS file found, so tagging you directly. This PR adds the required ci.yml workflow to resolve the compliance finding. Please review and merge when ready.

@sonarqubecloud

sonarqubecloud Bot commented Apr 7, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a required GitHub Actions CI entrypoint workflow that delegates execution to the org-level reusable CI workflow, addressing the missing-ci.yml compliance finding (closes #20).

Changes:

  • Introduces .github/workflows/ci.yml as a thin caller workflow for CI on push / pull_request to main
  • Delegates all CI logic to petry-projects/.github/.github/workflows/ci-reusable.yml@main
  • Sets job-level token permissions for the reusable workflow run

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml

jobs:
ci:
uses: petry-projects/.github/.github/workflows/ci-reusable.yml@main

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling a reusable workflow by a floating ref (@main) creates supply-chain risk and can cause unexpected behavior changes over time. Prefer pinning to an immutable ref (tag or full commit SHA) and periodically updating it intentionally.

Suggested change
uses: petry-projects/.github/.github/workflows/ci-reusable.yml@main
uses: petry-projects/.github/.github/workflows/ci-reusable.yml@<FULL_COMMIT_SHA>

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml
jobs:
ci:
uses: petry-projects/.github/.github/workflows/ci-reusable.yml@main
secrets: inherit

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using secrets: inherit passes all repository/environment secrets to the reusable workflow, which is broader than necessary for many CI runs. Consider explicitly mapping only the required secrets to reduce blast radius if the called workflow changes or is misused.

Suggested change
secrets: inherit
secrets: {}

Copilot uses AI. Check for mistakes.
@don-petry

Copy link
Copy Markdown
Contributor Author

Closing as stale — predates the standards PR.

This PR was generated by Claude during the original bulk-toggle yesterday, before petry-projects/.github#86 landed. That standards PR added prompt rules that:

  • Require copying from petry-projects/.github/standards/workflows/ verbatim instead of writing workflow files from scratch
  • Require verifying SHAs via gh api instead of guessing
  • Require the CodeQL actions ecosystem in the matrix where applicable
  • Allow gh api and gh label create for admin operations

Re-toggling the underlying issue will let Claude regenerate this fix using the new rules. The next run should produce a workflow that is byte-identical to the standard template (verified with the canary on TalkTerm#51 → PR #78 yesterday).

@don-petry don-petry closed this Apr 8, 2026
@don-petry
don-petry deleted the claude/issue-20-20260407-1732 branch April 8, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: missing-ci.yml

2 participants