Skip to content

feat: implement issue #401 — Compliance: non-stub-pr-review-mention.yml - #407

Merged
don-petry merged 2 commits into
mainfrom
dev-lead/issue-401-20260731-1422
Jul 31, 2026
Merged

feat: implement issue #401 — Compliance: non-stub-pr-review-mention.yml#407
don-petry merged 2 commits into
mainfrom
dev-lead/issue-401-20260731-1422

Conversation

@don-petry

@don-petry don-petry commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

User description

Closes #401

Implemented by dev-lead agent. Please review.


CodeAnt-AI Description

Route pull request review mentions through the v2 stable workflow channel

What Changed

  • Pull request review mentions now use the organization’s v2-stable workflow channel instead of the previous stable channel
  • Added coverage to ensure the canonical channel remains configured without changing existing review-related triggers

Impact

✅ Consistent review mention handling
✅ Protected pull request review triggers

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Chores
    • Updated the pull request review workflow to use the latest stable workflow channel.
    • Verified that workflow delegation now targets the updated channel while preserving existing triggers, permissions, and job behavior.

@don-petry
don-petry requested a review from a team as a code owner July 31, 2026 14:26
@codeant-ai

codeant-ai Bot commented Jul 31, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Incremental review completed 2359419 Jul 31, 2026 · 16:29 16:30
✅ Reviewed your PR b30f068 Jul 31, 2026 · 14:26 14:27

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jul 31, 2026
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Pin pr-review-mention workflow to org reusable v2-stable channel

⚙️ Configuration changes 🧪 Tests 🕐 10-20 Minutes

Grey Divider

AI Description

• Pin pr-review-mention caller workflow to the org reusable @pr-review-mention/v2-stable channel.
• Update Bats guard to enforce the new major-scoped stable pin per compliance standard (#401).
Diagram

graph TD
  A["GitHub PR/comment events"] --> B["Caller workflow: pr-review-mention.yml"] --> C["Org reusable: pr-review-mention/v2-stable"] --> D["Review mention side-effects"]
Loading
High-Level Assessment

This is a compliance-driven pin: the caller stub should delegate to the org reusable via the major-scoped stable channel (@pr-review-mention/v2-stable) to avoid drift while allowing centrally-managed updates. Alternatives like pinning to a bare tier (@.../stable) or a SHA conflict with the documented org standard and would increase maintenance burden.

Files changed (2) +8 / -4

Tests (1) +7 / -3
pr-review-mention-workflow.batsUpdate delegation test to require @pr-review-mention/v2-stable +7/-3

Update delegation test to require @pr-review-mention/v2-stable

• Renames and updates the Bats test to assert the workflow delegates to the org reusable at @pr-review-mention/v2-stable. Adds inline rationale explaining why bare tier pins are considered drift (issue #401).

scripts/tests/pr-review-mention-workflow.bats

Other (1) +1 / -1
pr-review-mention.ymlSwitch reusable workflow ref from stable to v2-stable +1/-1

Switch reusable workflow ref from stable to v2-stable

• Updates the 'uses:' reference for the pr-review-mention job to the major-scoped stable channel (@pr-review-mention/v2-stable). This aligns the stub workflow with the org centralization/versioning standard referenced in the file header.

.github/workflows/pr-review-mention.yml

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b4a3a9b-2140-4b7f-940d-d79f5d990b3d

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad27d0 and 2359419.

📒 Files selected for processing (2)
  • .github/workflows/pr-review-mention.yml
  • scripts/tests/pr-review-mention-workflow.bats

📝 Walkthrough

Walkthrough

The PR changes the reusable pr-review-mention workflow reference from stable to v2-stable. The delegation test now verifies the new channel.

Changes

PR review mention workflow

Layer / File(s) Summary
Update workflow channel
.github/workflows/pr-review-mention.yml, scripts/tests/pr-review-mention-workflow.bats
The reusable workflow uses pr-review-mention/v2-stable. The delegation test checks the same channel and updates its descriptions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: dev-lead:hands-off

Suggested reviewers: donpetry-bot

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-401-20260731-1422

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test suite in pr-review-mention-workflow.bats to verify that the workflow delegates to the major-scoped v2-stable channel instead of the bare stable channel, aligning with organization standards. There are no review comments, so I have no feedback to provide.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 31, 2026 14:30
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-31T15:32:30Z.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: b30f068ce387193771de62ffc7c4277367c2f1c5
Review mode: triage-approved (single reviewer)

Summary

Compliance fix for #401: repins the pr-review-mention caller stub from the bare @pr-review-mention/stable tier to the major-scoped @pr-review-mention/v2-stable channel, and updates the bats guard to enforce the new pin. Verified the v2-stable tag exists in petry-projects/.github and the changed uses: line matches the canonical stub template verbatim.

Linked issue analysis

Issue #401 (compliance audit, ci-workflows/error) requires the caller workflow to pin the major-scoped channel @pr-review-mention/v-stable instead of the bare stable tier. The PR applies exactly this remediation: the uses: ref now matches standards/workflows/pr-review-mention.yml verbatim (verified via GitHub API), and the tag refs/tags/pr-review-mention/v2-stable exists (e0bb289). The bats delegation guard was updated in lockstep so drift back to the bare tier fails CI. Issue substantively addressed.

Findings

No blocking findings.

  • The secrets block and permissions of the caller stub are unchanged; only the first-party channel ref moved, which complies with the org standard rather than deviating from it.
  • run_secret_scanning MCP tool was not available in this environment; the gitleaks CI check passed and the diff contains no secret-like content.
  • Advisory bots: Qodo (no issues), Gemini (no feedback), SonarCloud quality gate passed, AgentShield passed. CodeRabbit/Codex were rate-limited earlier; this is the post-window sweep re-review.
  • Risk assessed MEDIUM (workflow-file change) — a minor uplift from triage's low-risk call, but the change is verified against the canonical template so triage's approval stands.

CI status

All substantive checks green: Lint, Format, Test, Secret scan (gitleaks), CodeQL, SonarCloud, AgentShield, dependency-audit. Two CANCELLED dev-lead jobs (run 30638701206) were superseded by a later successful run of the same workflow (30638580228). Mergeable; state BLOCKED only pending review approval.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@codeant-ai codeant-ai Bot added size:XS This PR changes 0-9 lines, ignoring generated files and removed size:XS This PR changes 0-9 lines, ignoring generated files labels Jul 31, 2026
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 83dbdd6 into main Jul 31, 2026
23 of 24 checks passed
@don-petry
don-petry deleted the dev-lead/issue-401-20260731-1422 branch July 31, 2026 16:30
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-31T17:31:57Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: non-stub-pr-review-mention.yml

2 participants