Skip to content

feat: implement issue #348 — Compliance: stub-surface-drift-pr-auto-review.yml-concurrency - #373

Open
don-petry wants to merge 3 commits into
mainfrom
dev-lead/issue-348-20260721-1922
Open

feat: implement issue #348 — Compliance: stub-surface-drift-pr-auto-review.yml-concurrency#373
don-petry wants to merge 3 commits into
mainfrom
dev-lead/issue-348-20260721-1922

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #348

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings July 21, 2026 19:29
@don-petry
don-petry requested a review from a team as a code owner July 21, 2026 19:29
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 83a04d92-1011-4c3c-8513-6326d444fdfc

📥 Commits

Reviewing files that changed from the base of the PR and between cde0bce and d69b71d.

📒 Files selected for processing (2)
  • .github/workflows/pr-auto-review.yml
  • scripts/tests/pr-auto-review-workflow.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-348-20260721-1922

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pr-auto-review-workflow.bats test suite to assert that the pr-auto-review workflow stub does not declare a top-level concurrency block, aligning with its central management. Feedback was provided to use safe navigation when loading the YAML file (e.g., yaml.safe_load(...) or {}) to prevent potential TypeError exceptions if the file is empty.

Comment thread scripts/tests/pr-auto-review-workflow.bats Outdated
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) July 21, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the repository’s pr-auto-review.yml caller stub with the centrally owned workflow surface to resolve compliance finding #348 (stub-surface drift on concurrency). This fits the codebase’s pattern of using thin caller stubs that must mirror org standards verbatim for on:, permissions:, and centrally owned workflow attributes.

Changes:

  • Removed the locally defined top-level concurrency: block from .github/workflows/pr-auto-review.yml to eliminate drift from the canonical org template.
  • Updated the Bats workflow guard to assert that the caller stub does not declare a top-level concurrency: block, reflecting the centrally owned surface.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/tests/pr-auto-review-workflow.bats Updates the guardrails to enforce “no top-level concurrency” on the thin caller stub per compliance check #348.
.github/workflows/pr-auto-review.yml Removes the repo-local top-level concurrency: block to re-sync the stub with the org standard template surface.

@don-petry
don-petry disabled auto-merge July 21, 2026 19:59
@don-petry

Copy link
Copy Markdown
Contributor Author

Fixed in scripts/tests/pr-auto-review-workflow.bats line 25: added safe YAML load fallback (yaml.safe_load(...) or {}) to prevent TypeError when the workflow file is empty, making it consistent with the other tests on lines 32 and 43.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) July 21, 2026 20:00
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry
don-petry disabled auto-merge August 3, 2026 11:04
@don-petry
don-petry enabled auto-merge (squash) August 3, 2026 11:39
@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry
don-petry disabled auto-merge August 4, 2026 20:44
@don-petry
don-petry enabled auto-merge (squash) August 4, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: stub-surface-drift-pr-auto-review.yml-concurrency

3 participants