feat: implement issue #133 — Compliance: check-suite-auto-trigger-1236702 - #172
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR applies two repository configuration updates: adding ChangesRepository configuration and compliance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates scripts/apply-repo-settings.sh to disable the Claude app's check-suite auto-trigger, preventing orphaned check suites from blocking auto-merges. It also introduces a duplicate entry in the .gitignore file, which should be removed to maintain file clarity.
| @@ -1 +1,2 @@ | |||
| .dev-lead/ | |||
| .dev-lead/ | |||
There was a problem hiding this comment.
This entry is a duplicate of the one on line 1. Redundant entries in .gitignore should be removed to maintain file clarity.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Implements compliance fix for issue #133 by disabling a GitHub App check-suite auto-trigger that creates orphaned/never-completing check suites and blocks auto-merge.
Changes:
- Adds a
gh apicall to disable check-suite auto-trigger for the Claude GitHub App (app id1236702). - Updates
.gitignore(currently adds a duplicate ignore entry).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/apply-repo-settings.sh | Adds a repo settings update to disable check-suite auto-trigger for a specific GitHub App via the REST API. |
| .gitignore | Adds an ignore entry (currently duplicated). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gh api -X PATCH "repos/$REPO/check-suites/preferences" --input - <<'JSON' | ||
| { | ||
| "auto_trigger_checks": [ | ||
| { | ||
| "app_id": 1236702, | ||
| "setting": false | ||
| } | ||
| ] | ||
| } | ||
| JSON | ||
|
|
| echo "Disabling check-suite auto-trigger for Claude app (id: 1236702)..." | ||
|
|
||
| gh api -X PATCH "repos/$REPO/check-suites/preferences" --input - <<'JSON' |
|
…6702 (#172) Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Closes #133
Implemented by dev-lead agent. Please review.
Summary by CodeRabbit