Skip to content

feat: implement issue #149 — Compliance: ci-concurrency-missing-sha - #161

Merged
don-petry merged 10 commits into
mainfrom
dev-lead/issue-149-20260520-1457
May 21, 2026
Merged

feat: implement issue #149 — Compliance: ci-concurrency-missing-sha#161
don-petry merged 10 commits into
mainfrom
dev-lead/issue-149-20260520-1457

Conversation

@don-petry

@don-petry don-petry commented May 20, 2026

Copy link
Copy Markdown
Contributor

Closes #149

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration to improve handling of concurrent builds.

Review Change Stack

Copilot AI review requested due to automatic review settings May 20, 2026 14:58
@don-petry
don-petry requested a review from a team as a code owner May 20, 2026 14:58
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 14b53ade-3f9c-46eb-8ebb-cd3c915a9cea

📥 Commits

Reviewing files that changed from the base of the PR and between a65eb22 and ab457fe.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow concurrency group is updated to include the commit SHA alongside the git ref, ensuring that rapid successive pushes do not cancel in-progress CI runs for earlier commits.

Changes

CI Concurrency

Layer / File(s) Summary
Concurrency group SHA inclusion
.github/workflows/ci.yml
The concurrency.group template is updated from ci-${{ github.ref }} to ci-${{ github.ref }}-${{ github.sha }} to prevent HEAD commits from losing CI results when pushes arrive in quick succession.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • petry-projects/.github#246: Both changes modify GitHub Actions concurrency.group to include ${{ github.sha }} in CI workflow configuration.

Possibly related PRs

  • petry-projects/ContentTwin#175: Both PRs modify GitHub Actions workflow concurrency configuration to update concurrency group and cancellation policies.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the implementation of issue #149 regarding CI concurrency missing SHA, directly matching the pull request's primary objective.
Linked Issues check ✅ Passed The code change successfully implements the required remediation by updating the concurrency group to include both ref and sha, addressing issue #149's compliance requirement.
Out of Scope Changes check ✅ Passed The pull request contains only the necessary change to the CI concurrency group configuration, with no out-of-scope modifications beyond the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-149-20260520-1457

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6df5d247ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to exclude the .dev-lead/ directory from version control. I have no feedback to provide as there were no review comments to evaluate.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses compliance issue #149 by updating the CI workflow’s concurrency group to include the commit SHA, preventing the HEAD commit’s CI run from being cancelled by subsequent pushes on the same ref.

Changes:

  • Update .github/workflows/ci.yml concurrency group to ci-${{ github.ref }}-${{ github.sha }} per the org CI standard.
  • Add .dev-lead/ to .gitignore to avoid committing dev-lead agent artifacts.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Updates CI concurrency grouping to include github.sha to meet compliance requirement.
.gitignore Ignores .dev-lead/ directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ce5188325

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77c694dfee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: ci-concurrency-missing-sha

3 participants