fix(org-status): avoid ARG_MAX crash with 200+ open PRs by don-petry · Pull Request #258 · petry-projects/.github

don-petry · 2026-05-12T18:20:26Z

Summary

Root cause: jq -n --argjson a "$ALL_PRS" --argjson b "$prs" passes the accumulated PR array as a shell argument. After 252 PRs across 8 repos the variable exceeded Linux's ARG_MAX limit (~3 MB on this runner), causing exit 126 (E2BIG: Argument list too long) in run 25736549959.
Fix: Both the PR and issues accumulation loops now use the NDJSON pattern already established in the Behind-Base Detection section — emit one compact JSON line per item into a string variable, slurp into an array once at the end with jq -cs '.'. No batch data ever passes through a command-line argument.
Issues loop also fixed pre-emptively — same pattern, same failure mode once issue counts grow.

Regression proof

Synthetic dataset: 8 repos × 35 PRs = 280 PRs (matching live scale).

=== Reproducing ARG_MAX failure with OLD pattern ===
CONFIRMED FAIL after repo=eta: Argument list too long

=== Testing NEW pattern (NDJSON accumulation) ===
SUCCESS: accumulated 280 PRs without hitting ARG_MAX
NDJSON variable size: 159076 bytes (155 KB)

Test plan

Confirm CI lint passes (shellcheck, actionlint)
Re-trigger the daily workflow manually (workflow_dispatch) or wait for next scheduled run — expect the "Generate org status report" step to succeed

🤖 Generated with Claude Code

Passing a growing JSON array via `jq --argjson` exceeds the Linux kernel's ARG_MAX limit (~2-3 MB) once enough PR data accumulates. The daily run hit this at 252 PRs across 8 repos (exit code 126, "Argument list too long"). Switch both the PR and issues accumulation loops to the NDJSON pattern already used in the Behind-Base Detection section: emit one compact JSON line per item into a string variable, then slurp into an array once at the end with `jq -cs '.'`. No PR/issue data ever passes through a command-line argument. Regression test (8 repos × 35 PRs = 280 synthetic PRs): - Old pattern: Argument list too long at repo 7/8 - New pattern: 280 PRs accumulated successfully Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-05-12T18:20:34Z

Warning

Rate limit exceeded

@don-petry has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 10 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c692e234-4c6b-4dfd-a416-8bc12d96e519

📥 Commits

Reviewing files that changed from the base of the PR and between fea867c and 92d7fe1.

📒 Files selected for processing (1)

scripts/org_status.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/org-status-argmax-large-pr-sets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR updates scripts/org_status.sh to prevent Linux ARG_MAX failures when aggregating large numbers of open PRs/issues across many repositories by switching from “grow a JSON array via --argjson” to an NDJSON accumulation + final slurp approach.

Changes:

Accumulate PRs as NDJSON (one compact JSON object per line) and slurp once at the end with jq -cs '.'.
Apply the same NDJSON pattern to the issues aggregation loop to avoid the same failure mode as issue volume grows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gemini-code-assist

Code Review

This pull request refactors scripts/org_status.sh to use NDJSON accumulation for pull requests and issues, effectively preventing ARG_MAX errors when handling large datasets. Feedback suggests applying this pattern to other sections of the script, such as merge activity and internal PR collection, for complete robustness. Additionally, the reviewer recommends using Bash here-strings (<<<) instead of echo or printf for more idiomatic and safer piping of variable content to jq.

…< style Address Gemini review on PR #258: - collect_classify_prs: replace --argjson page accumulation (all_nodes) with NDJSON pattern; protects against repos with many PR pages, not just large org totals. Also switch echo | jq to <<< throughout the function. - Merge activity: write ORG_MERGES/PERSONAL_MERGES to DATA_DIR/merges.json via printf (bash builtin, no exec, no ARG_MAX) so MERGE_DAILY and MERGE_BY_REPO_DAY read from a file descriptor instead of --argjson args. - All remaining echo "$x" | jq and printf | jq replaced with <<< herestrings as suggested (more idiomatic, avoids echo flag interpretation edge case). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

sonarqubecloud · 2026-05-12T18:56:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

* fix(org-status): avoid ARG_MAX crash when org has 200+ open PRs Passing a growing JSON array via `jq --argjson` exceeds the Linux kernel's ARG_MAX limit (~2-3 MB) once enough PR data accumulates. The daily run hit this at 252 PRs across 8 repos (exit code 126, "Argument list too long"). Switch both the PR and issues accumulation loops to the NDJSON pattern already used in the Behind-Base Detection section: emit one compact JSON line per item into a string variable, then slurp into an array once at the end with `jq -cs '.'`. No PR/issue data ever passes through a command-line argument. Regression test (8 repos × 35 PRs = 280 synthetic PRs): - Old pattern: Argument list too long at repo 7/8 - New pattern: 280 PRs accumulated successfully Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * fix(org-status): address review comments — full ARG_MAX coverage + <<< style Address Gemini review on PR #258: - collect_classify_prs: replace --argjson page accumulation (all_nodes) with NDJSON pattern; protects against repos with many PR pages, not just large org totals. Also switch echo | jq to <<< throughout the function. - Merge activity: write ORG_MERGES/PERSONAL_MERGES to DATA_DIR/merges.json via printf (bash builtin, no exec, no ARG_MAX) so MERGE_DAILY and MERGE_BY_REPO_DAY read from a file descriptor instead of --argjson args. - All remaining echo "$x" | jq and printf | jq replaced with <<< herestrings as suggested (more idiomatic, avoids echo flag interpretation edge case). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings May 12, 2026 18:20

don-petry requested a review from a team as a code owner May 12, 2026 18:20

Copilot started reviewing on behalf of don-petry May 12, 2026 18:21 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

gemini-code-assist Bot reviewed May 12, 2026

View reviewed changes

Comment thread scripts/org_status.sh

Comment thread scripts/org_status.sh Outdated

Comment thread scripts/org_status.sh Outdated

Comment thread scripts/org_status.sh Outdated

Comment thread scripts/org_status.sh Outdated

coderabbitai Bot approved these changes May 12, 2026

View reviewed changes

don-petry enabled auto-merge (squash) May 12, 2026 18:57

don-petry merged commit 8558fa5 into main May 12, 2026
20 checks passed

don-petry deleted the fix/org-status-argmax-large-pr-sets branch May 12, 2026 19:00

don-petry mentioned this pull request May 12, 2026

chore: rename compliance workflow to "Org Standards Compliance Audit" #264

Closed

1 task

Navigation Menu

Uh oh!

fix(org-status): avoid ARG_MAX crash with 200+ open PRs - #258

fix(org-status): avoid ARG_MAX crash with 200+ open PRs#258
don-petry merged 2 commits into
mainfrom
fix/org-status-argmax-large-pr-sets

don-petry commented May 12, 2026

Uh oh!

coderabbitai Bot commented May 12, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

Copilot AI left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

don-petry commented May 12, 2026

Summary

Regression proof

Test plan

Uh oh!

coderabbitai Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 12, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented May 12, 2026 •

edited

Loading