Skip to content

feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27 - #489

Merged
don-petry merged 8 commits into
mainfrom
dev-lead/issue-400-20260608-0047
Jun 8, 2026
Merged

feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27#489
don-petry merged 8 commits into
mainfrom
dev-lead/issue-400-20260608-0047

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #400

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings June 8, 2026 01:03
@don-petry
don-petry requested a review from a team as a code owner June 8, 2026 01:03
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 54 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bdd39b6c-23ff-45cc-8475-8b9d482567f1

📥 Commits

Reviewing files that changed from the base of the PR and between ff4c6b0 and df11972.

📒 Files selected for processing (5)
  • .github/workflows/ci-failure-analyst-reusable.yml
  • .github/workflows/issue-triage-runner.yml
  • scripts/engine.sh
  • tests/dev-lead/unit/test_engine_fallback.bats
  • tests/dev-lead/unit/test_engine_writer.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-400-20260608-0047

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check to skip the Gemini fallback in scripts/engine.sh if neither GEMINI_API_KEY nor GOOGLE_API_KEY is configured, and includes unit tests to verify this behavior. The feedback suggests updating the warning message to mention both environment variables to accurately reflect the conditional check.

Comment thread scripts/engine.sh

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b978c228f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/engine.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — rate-limited (intent: review-changes)

PR: #489
The retry cron will re-attempt automatically.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I received your request but all AI engines are currently rate-limited. I'll retry automatically once the rate limit clears.
Rate limit resets at: unknown

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:37
@don-petry
don-petry disabled auto-merge June 8, 2026 05:00
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:08
@don-petry
don-petry disabled auto-merge June 8, 2026 05:08
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:11
@don-petry
don-petry disabled auto-merge June 8, 2026 05:12
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 1 — Quality Gate passed with 0 new issues, 0 security hotspots, 0 duplication; no open review threads from this bot exist to resolve
```
The SonarCloud report is purely a passing status notification. There are no actionable findings, no open review threads from `sonarqubecloud[bot]`, and no Tier 1 blockers in the PR. No changes are needed.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:12
@don-petry
don-petry disabled auto-merge June 8, 2026 05:23
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:26

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 9129739e8aac989a4ab67da44ae981a74aa5ed68
Review mode: triage-approved (single reviewer)

Summary

Three coordinated fixes addressing workflow failures from issue #400:

  1. ci-failure-analyst-reusable.yml — captures claude output via tee and exits 0 with a ::notice:: when the run fails with a rate-limit/quota signal, so transient quota errors stop turning into red CI runs.
  2. issue-triage-runner.yml — replaces the anthropics/claude-code-action/setup action (failing 100% in this repo) with a direct npm install -g @anthropic-ai/claude-code@${CLAUDE_CODE_VERSION} step, version-pinnable via vars.CLAUDE_CODE_VERSION. The OAuth token is correctly relocated to the run step that actually invokes claude via scripts/aw.sh.
  3. scripts/engine.sh — adds a guard that skips gemini in the writer fallback chain when neither GEMINI_API_KEY nor GOOGLE_API_KEY is set, mirroring the existing copilot PAT skip pattern.

Linked issue analysis

Issue #400 is the 2026-05-27 fleet health report. It explicitly calls out issue-triage-runner.yml at 100% failure rate in .github-private, plus ci-failure-analyst.yml failing across three repos. This PR directly targets both, and the engine.sh change removes a noisy fallback path that contributes to dev-lead failures observed elsewhere in the same report. Substantively addressed.

Findings

  • None blocking. The PIPESTATUS handling in ci-failure-analyst-reusable.yml is correct (PIPESTATUS[0] is captured inside the || arm, which only runs on pipe failure under pipefail; success path leaves _analyst_rc=0). The rate-limit grep pattern is anchored to common Anthropic phrasing and is case-insensitive.
  • Nit (non-blocking): issue-triage-runner.yml defaults CLAUDE_CODE_VERSION to 'latest', replacing a SHA-pinned action with a floating npm tag. Override path via vars.CLAUDE_CODE_VERSION exists, but consider pinning that repo/org variable to a specific version to recover supply-chain pinning parity with other workflows in this repo.
  • The gemini-code-assist suggestion (mention both env vars in the warning) is already reflected in the implementation: GEMINI_API_KEY or GOOGLE_API_KEY not configured.
  • Test coverage: new bats tests assert both that gemini is skipped when unset (and copilot succeeds) and that it is invoked normally when GEMINI_API_KEY is set. The existing test_engine_writer.bats is correctly updated to set a dummy GEMINI_API_KEY so unrelated writer tests still exercise the gemini path.

CI status

All required checks passing: Lint, shellcheck, bats, unit-tests, Compile agentic workflows, validate-agent-profiles, Agent Security Scan, Secret scan (gitleaks), Analyze (actions), Analyze (python), SonarCloud Code Analysis (Quality Gate passed — 0 new issues, 0 security hotspots), agent-shield, gh-aw-compile. Dependency-audit skipped (no relevant ecosystems changed). No HIGH-risk signals.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry
don-petry disabled auto-merge June 8, 2026 05:35
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:37
@don-petry
don-petry disabled auto-merge June 8, 2026 05:41
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 1
  - Quality Gate passed (0 new issues, 0 security hotspots, 0.0% duplication)
    — no actionable findings; no open review threads to resolve
```

@don-petry
don-petry deleted the dev-lead/issue-400-20260608-0047 branch June 8, 2026 06:09
don-petry added a commit that referenced this pull request Jun 8, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 12, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 13, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 13, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 14, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 15, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 18, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 21, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 2, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 3, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 3, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…ted 2026-05-27 (#489)

* feat: implement issue #400 — petry-projects — workflow failures detected 2026-05-27

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

petry-projects — workflow failures detected 2026-05-27

3 participants