feat: implement issue #1401 — pr-review: register Graphite as an advisory reviewer + fix ADVISORY_REVIEW_GATE.md doc drift (follow-up to #1349 / #1355) - #1412
Conversation
🤖 CodeAnt AI — Review Status
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughGraphite is added to advisory review detection, rate-limit handling, reviewer reporting, documentation, fixtures, and unit tests. The tests cover Graphite review recognition and quota-limit classification. ChangesGraphite advisory registration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:M
PR Summary by QodoRegister Graphite as advisory reviewer and align gate/report docs + tests
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request registers Graphite (graphite-app) as an advisory reviewer bot across the advisory review gate, reports, documentation, and tests. This includes updating the bot registries, adding mock event fixtures, and introducing new unit tests to verify Graphite's detection and rate-limit classification. I have no feedback to provide on this pull request.
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
Code Review by Qodo
Context used✅ Compliance rules (platform):
48 rules 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/pr-review-agent/ADVISORY_REVIEW_GATE.md:
- Around line 220-234: Update the advisory bot-count documentation to match all
seven entries in ADVISORY_BOTS, including the gate wait count and the “All bots
present” and partial-presence examples. If the gate intentionally waits for
fewer bots, explicitly identify the remaining bots as optional instead of
implying all seven are required.
In `@scripts/reviewer_report.sh`:
- Line 72: Update the reviewer_report test fixture’s BOTS list to include
graphite-app, then extend the report assertions to verify it normalizes to the
Graphite label. Keep the existing reviewer identities and normalization
expectations unchanged.
In `@tests/dev-lead/unit/test_advisory_review_gate.bats`:
- Around line 849-873: Update both runtime tests around check_advisory_reviews
to assert the expected successful exit status via $status, and require the
Graphite result to include both “graphite-app” and its expected state: COMMENTED
for the review test and RATE_LIMITED for the quota test. Keep the existing
output checks while adding these precise state assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e828e1fc-27c2-410b-adca-de0375ec7a62
📒 Files selected for processing (7)
.claude/pr-review-agent/ADVISORY_REVIEW_GATE.mddocs/reviewer-report.mdscripts/lib/advisory-review-gate.shscripts/reviewer_report.shtests/dev-lead/fixtures/events/advisory_graphite_rate_limited.jsontests/dev-lead/fixtures/events/advisory_graphite_reviewed.jsontests/dev-lead/unit/test_advisory_review_gate.bats
|
@coderabbitai resolve |
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1412 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
✅ Action performedComments resolved and changes approved. |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
Auto-dismissed (#617): coderabbitai[bot] CHANGES_REQUESTED on a superseded commit. The bot re-reviews the new head automatically — a valid concern will return as a fresh review.
|
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1412 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 956330c82673abb84bbaf92542c494c0554542c0
Review mode: triage-approved (single reviewer)
Summary
Small, additive PR (+83/−15, 8 files) registering Graphite (graphite-app) as a tracked advisory reviewer and fixing ADVISORY_REVIEW_GATE.md doc drift, exactly as scoped in issue #1401. Changes are registry-entry additions in scripts/lib/advisory-review-gate.sh and scripts/reviewer_report.sh, doc updates, plus fixtures and bats coverage. No logic changes, no new dependencies, no secrets. The triage tier's low-risk assessment is confirmed.
Linked issue analysis
Issue #1401 checklist is fully addressed:
- Verify login (not guess): independently confirmed —
graphite-appappears as a real GraphQL.author.loginon PR #1355 reviews, satisfying the "do not guess identifiers" guardrail. - Registries: added to
ADVISORY_BOTS,RATE_LIMIT_NOTICE_BOTS, theREVIEWER_BOTSfallback list, andREVIEWER_LABELSwith display name "Graphite". - Fixtures + tests: new
advisory_graphite_reviewed.json/advisory_graphite_rate_limited.jsonfixtures with 4 new bats tests mirroring the Qodo/CodeAnt pattern (registration, superset membership, review detection, RATE_LIMITED classification); existing count assertions updated 7→8. - Docs:
docs/reviewer-report.mdtracked-reviewer table updated;ADVISORY_REVIEW_GATE.mdexample registry brought current with a source-of-truth note and a CodeRabbit-exclusion clarification.
Findings
No blocking findings.
- Secret scan:
run_secret_scanningMCP tool not available in this run; gitleaks CI check passed and the diff contains no credential-like content (fixtures are synthetic bot messages). - Nit (non-blocking): the reworded header comment in
scripts/reviewer_report.shwraps awkwardly ("...weekly Markdown report. / No LLM is / used...") — cosmetic only. - All 5 bot review threads (CodeAnt, Qodo, CodeRabbit ×3) are resolved; CodeRabbit's latest review is APPROVED; no changes-requested reviews and no unanswered human-reviewer questions.
CI status
All substantive checks green at 956330c: shellcheck, bats, unit-tests, validate-fixtures, CodeQL (actions + python), gitleaks secret scan, AgentShield, SonarCloud quality gate, actionlint, and all stub/permission guards SUCCESS. The CANCELLED entries are superseded runs of the review/dev-lead orchestration workflows themselves (concurrency-cancelled after the fix-bot-comment push); dependency-audit jobs SKIPPED (no matching ecosystems). No failing validators.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-08-02T02:38:56Z. |
2 participants
User description
Closes #1401
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Register Graphite as a tracked advisory reviewer
What Changed
Impact
✅ Graphite reviews appear in PR review status✅ Fewer merge delays when Graphite reaches its usage limit✅ Consistent reviewer documentation💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
New Features
Documentation