fix(cut-release): set a git identity before the this-repo annotated-tag cut (#1069) by don-petry · Pull Request #1075 · petry-projects/.github-private

don-petry · 2026-07-04T13:04:50Z

Bug (caught by the armed autocut)

The first armed autocut run cut auto-rebase v2.1.1 + dependency-audit v2.1.1 successfully (cross-repo, via gh api), but dev-lead's cut failed:

fatal: empty ident name (for <runner@...cloudapp.net>) not allowed

dev-lead is the one THIS_REPO agent, so its cut goes through local git (cut-release.sh → git tag -a, an annotated tag), which needs a tagger user.name/user.email. A GitHub-hosted runner has none. Cross-repo agents cut via gh api (App identity), so they're unaffected — which is exactly why only dev-lead failed. Armed, the timer would retry + fail every 4h.

Fix

cut-release.sh now sources the shared scripts/lib/git-identity.sh and calls setup_git_identity immediately before the local git tag -a. Verified locally: resolves to donpetry-bot / 281750570+donpetry-bot@users.noreply.github.com. Sourcing is side-effect-free, so the test source-guard contract holds. +1 regression guard (helper is wired). 42/42 cut-release tests pass.

Validation

Acceptance = re-dispatch autocut after merge and confirm dev-lead v1.5.1 cuts (the same run that already succeeded for the two cross-repo agents). Will confirm on merge.

Refs: #1069 (autocut) · #959/#992 (cut-release cross-repo/promote).

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved release tag creation so annotated tags work more reliably in local and hosted environments.
- Prevented release failures when Git identity settings are missing.
Tests
- Added coverage for the release flow to confirm the Git identity setup is available during tag creation.

…ag cut (#1069) The armed autocut cut auto-rebase v2.1.1 and dependency-audit v2.1.1 fine (cross-repo, via gh api) but dev-lead's cut failed: fatal: empty ident name (for <runner@...>) not allowed dev-lead is the one THIS_REPO agent, so its cut goes through local git (`git tag -a`, an annotated tag), which needs a tagger identity — and a GitHub-hosted runner has none. Cross-repo cuts use gh api (App identity) and are unaffected. Fix: source the shared scripts/lib/git-identity.sh and call setup_git_identity right before `git tag -a` in the this-repo path. +regression guard that the helper is wired. 50/50 cut-release tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector · 2026-07-04T13:04:54Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

coderabbitai · 2026-07-04T13:05:06Z

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3e1e5b78-fa41-403b-82f3-2a5105c5667f

📥 Commits

Reviewing files that changed from the base of the PR and between a9ef3b9 and c469676.

📒 Files selected for processing (2)

scripts/cut-release.sh
tests/test_cut_release.bats

📝 Walkthrough

Walkthrough

The cut-release.sh script now sources a shared lib/git-identity.sh helper and calls setup_git_identity before creating annotated tags in the this-repo tag path, ensuring a valid tagger identity. A new Bats test verifies setup_git_identity is declared after sourcing the script.

Changes

Git identity bootstrap for release tagging

Layer / File(s)	Summary
Source and invoke setup_git_identity before tagging `scripts/cut-release.sh`, `tests/test_cut_release.bats`	Script sources `lib/git-identity.sh` and calls `setup_git_identity` before `git tag -a` in the this-repo annotated-tag path; a new test asserts the function is declared after sourcing.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

petry-projects/.github-private#369: Wires the same setup_git_identity helper before git commit in commit_and_push().
petry-projects/.github-private#1070: Adds canary-rollout.sh autocut which invokes the hardened cut-release.sh.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main fix: setting a Git identity before the this-repo annotated-tag cut.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/cut-release-git-identity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request integrates a shared git-identity helper into the release script and invokes it before creating annotated tags, preventing failures on bare GitHub-hosted runners that lack a configured git identity. A corresponding test has also been added to verify the integration. The feedback suggests making the script's path resolution more robust by using "cd -P --" and "pwd -P", and declaring the path variable as "readonly".

Copilot

Pull request overview

Fixes cut-release.sh failing on GitHub-hosted runners when cutting this-repo (local) annotated tags due to missing user.name/user.email, by wiring in the shared git identity helper right before git tag -a.

Changes:

Source scripts/lib/git-identity.sh from scripts/cut-release.sh and invoke setup_git_identity immediately before creating the local annotated release tag.
Add a Bats regression test asserting setup_git_identity is available after sourcing cut-release.sh.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
scripts/cut-release.sh	Sources the shared git identity helper and sets a tagger identity before local annotated tag creation to prevent “empty ident name” failures on runners.
tests/test_cut_release.bats	Adds a regression guard ensuring the git identity helper is wired when `cut-release.sh` is sourced.

don-petry · 2026-07-04T13:07:39Z

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #1075
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-04T13:37:38Z

don-petry · 2026-07-04T13:07:40Z

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-04T13:37:38Z

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/test_cut_release.bats`:
- Around line 17-24: The current test only verifies that setup_git_identity
exists after sourcing cut-release.sh, so it does not protect the this-repo
annotated-tag flow from regressions. Update the test in test_cut_release.bats to
exercise the actual this-repo path in scripts/cut-release.sh by either invoking
main with stubs for git/gh and asserting setup_git_identity runs before git tag
-a configures user.name/user.email, or by asserting the source order around the
this-repo tag branch. Reference setup_git_identity, main, and the this-repo tag
path so the guard fails if the helper call is removed.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 421eb963-fba8-4728-933b-b847dd7c2425

📥 Commits

Reviewing files that changed from the base of the PR and between 7d1f684 and a9ef3b9.

📒 Files selected for processing (2)

scripts/cut-release.sh
tests/test_cut_release.bats

don-petry · 2026-07-04T13:12:58Z

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

sonarqubecloud · 2026-07-04T13:14:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

don-petry · 2026-07-04T13:15:38Z

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #1075
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-04T13:45:36Z

don-petry · 2026-07-04T13:15:39Z

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-04T13:45:36Z

…ag cut (#1069) (#1075) * fix(cut-release): set a git identity before the this-repo annotated-tag cut (#1069) The armed autocut cut auto-rebase v2.1.1 and dependency-audit v2.1.1 fine (cross-repo, via gh api) but dev-lead's cut failed: fatal: empty ident name (for <runner@...>) not allowed dev-lead is the one THIS_REPO agent, so its cut goes through local git (`git tag -a`, an annotated tag), which needs a tagger identity — and a GitHub-hosted runner has none. Cross-repo cuts use gh api (App identity) and are unaffected. Fix: source the shared scripts/lib/git-identity.sh and call setup_git_identity right before `git tag -a` in the this-repo path. +regression guard that the helper is wired. 50/50 cut-release tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(reviews): address review comments [skip ci-relay] --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

don-petry requested a review from a team as a code owner July 4, 2026 13:04

Copilot AI review requested due to automatic review settings July 4, 2026 13:04

don-petry added the dev-lead For dev-lead agent pickup label Jul 4, 2026

Copilot started reviewing on behalf of don-petry July 4, 2026 13:05 View session

gemini-code-assist Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread scripts/cut-release.sh Outdated

Copilot AI reviewed Jul 4, 2026

View reviewed changes

don-petry enabled auto-merge (squash) July 4, 2026 13:07

coderabbitai Bot requested changes Jul 4, 2026

View reviewed changes

Comment thread tests/test_cut_release.bats

don-petry disabled auto-merge July 4, 2026 13:08

coderabbitai Bot previously approved these changes Jul 4, 2026

View reviewed changes

fix(reviews): address review comments [skip ci-relay]

c469676

don-petry dismissed coderabbitai[bot]’s stale review via c469676 July 4, 2026 13:12

don-petry enabled auto-merge (squash) July 4, 2026 13:13

coderabbitai Bot approved these changes Jul 4, 2026

View reviewed changes

don-petry disabled auto-merge July 4, 2026 13:13

don-petry enabled auto-merge (squash) July 4, 2026 13:15

don-petry merged commit 2b8b902 into main Jul 4, 2026
32 of 40 checks passed

don-petry deleted the fix/cut-release-git-identity branch July 4, 2026 13:16

coderabbitai Bot mentioned this pull request Jul 4, 2026

fix(release): unify channel-tag moves onto the gh-api/App-token path (#1076) #1087

Merged

github-actions Bot mentioned this pull request Jun 4, 2026

petry-projects — workflow failures detected 2026-06-04 #429

Closed

Uh oh!

Conversation

don-petry commented Jul 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug (caught by the armed autocut)

Fix

Validation

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Jul 4, 2026

Uh oh!

coderabbitai Bot commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

don-petry commented Jul 4, 2026

Dev-Lead — waiting on PR blockers (intent: review-changes)

Uh oh!

don-petry commented Jul 4, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

don-petry commented Jul 4, 2026

Dev-Lead — fix-reviews (applied)

Uh oh!

sonarqubecloud Bot commented Jul 4, 2026

Quality Gate passed

Uh oh!

don-petry commented Jul 4, 2026

Dev-Lead — waiting on PR blockers (intent: review-changes)

Uh oh!

don-petry commented Jul 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

don-petry commented Jul 4, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 4, 2026 •

edited

Loading