feat: implement issue #1008 — Onboard idea→initiative pipeline reusables into canary-rollout (planner/triage ready; enhancer/feature-ideation blocked)

[don-petry]

Closes #1008

Implemented by dev-lead agent. Please review.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0b65aee7-efb2-4126-a777-93aced916359

📥 Commits

Reviewing files that changed from the base of the PR and between 41961a8 and 122eb97.

📒 Files selected for processing (3)

• scripts/canary-rollout.sh
• standards/canary-rings.json
• tests/canary_rollout.bats

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev-lead/issue-1008-20260702-1353

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[donpetry-bot]

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-02T15:03:27Z.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
Files changed: None
Skipped (informational): 0
Status: Quality Gate passed — no actionable issues found.
```
The pull request is ready for merge from a code quality and security perspective.

[gemini-code-assist]

Code Review

This pull request onboards the initiative-planner and idea-triage pipeline agents to standards/canary-rings.json, registers initiative-driver as an unmanaged workflow, and adds corresponding test coverage in tests/canary_rollout.bats. However, several issues need to be addressed: the newly introduced soak_start_ring and next_tier_health_signal fields are not yet implemented in the promotion script, which will cause promotions to hang; idea-triage is missing its next_tier_health_signal configuration; and the test assertions can be simplified by removing an unnecessary bash -c shell invocation and a redundant // null fallback in jq.

[Copilot]

Pull request overview

This PR updates the canary-rollout ring single-source-of-truth (standards/canary-rings.json) to onboard the idea→initiative pipeline reusables (initiative-planner, idea-triage) and to explicitly record initiative-driver as out-of-model/unmanaged, along with Bats coverage to lock in the intended config shape.

Changes:

• Adds initiative-planner and idea-triage agent entries to standards/canary-rings.json with soak_start_ring=ring1 and ring member lists.
• Adds an unmanaged.initiative-driver record so it’s explicitly excluded from .agents.
• Extends tests/canary_rollout.bats with shape/guard assertions for the new SoT entries and exclusions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/canary_rollout.bats	Adds unit tests asserting the intended canary-rings.json onboarding/exclusion shape for #1008.
standards/canary-rings.json	Extends ring SoT with new agents and an unmanaged record for initiative-driver per #1008.

[don-petry]

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

[don-petry]

Dev-Lead — review-changes (applied)

Changes committed and pushed.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
Files changed: none
Skipped (informational): 0
```

[don-petry]

Dev-Lead — review-changes (applied)

Changes committed and pushed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[donpetry-bot]

Automated review — human attention needed

This PR has been through 3 automated review cycles since the last approval or escalation (cap: 3) without converging. Further automated review has been paused to avoid infinite loops.

Please take a look manually, or close this PR if it's no longer needed. To re-engage the automated cascade with a fresh cycle budget, either remove the needs-human-review label, or mention the bot (e.g. @donpetry-bot review) for an immediate re-review.

Posted by the donpetry-bot PR-review cascade.

[donpetry-bot]

@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes.

[donpetry-bot]

Review — fix requested (cycle 1/3)

The automated review identified the following issues. Please address each one:

Findings to fix

Automated review — NEEDS HUMAN REVIEW

Risk: MEDIUM
Reviewed commit: 122eb977fa665f62cda9a86d7b874b845cbf67ee
Review mode: triage-approved (single reviewer)

Summary

Onboards initiative-planner and idea-triage into canary-rings.json with a new soak_start_ring / next_tier_health_signal mechanism in _frontier_state, records initiative-driver as unmanaged, and keeps idea-enhancer / feature-ideation out per the issue. Structure, tests, and exclusions match issue #1008, and all prior bot-review threads were addressed. However, verification against the live org repos shows the new health-signal wiring cannot produce evidence in production for either onboarded agent (details below), which recreates the permanent-SOAKING failure mode this PR was amended to fix.

Linked issue analysis

Issue #1008 asks to onboard planner + triage (ready), record initiative-driver as unmanaged, and exclude idea-enhancer (no tags/callers) and feature-ideation (bug #571 + missing channel tags). The PR implements all four dispositions and adds bats coverage for each, including run_workflow thin-stub names fixed per review feedback. Two spec details are not correctly realized: (1) the issue states initiative-planner's canary lives in petry-projects/.github-private, but the script queries the agent's host repo (petry-projects/.github); (2) the issue explicitly says idea-triage has NO canary and requires choosing between accepting ring1 as its floor or adding a triage canary — the PR instead references a canary workflow that does not exist.

Findings

1. [MEDIUM — correctness] scripts/canary-rollout.sh (_frontier_state): the pre-soak health branch sets src_repos to the agent's host (petry-projects/.github) and queries next_tier_health_signal there. Verified via the GitHub API: petry-projects/.github has no canary workflows; initiative-planner-canary.yml exists only in petry-projects/.github-private. Since _run_json suppresses errors and returns [], the gate silently computes sample=0 — the health signal never provides evidence. Fix: make the signal repo explicit (e.g. a next_tier_health_repo field or repo-qualified signal value) rather than assuming host.
2. [MEDIUM — correctness/config] standards/canary-rings.json: idea-triage.next_tier_health_signal references .github/workflows/idea-triage-canary.yml, which does not exist in petry-projects/.github or .github-private (verified). Issue Onboard idea→initiative pipeline reusables into canary-rollout (planner/triage ready; enhancer/feature-ideation blocked) #1008 explicitly flags that idea-triage has no canary and requires an owner decision (accept ring1 as the floor, or create the canary first). Referencing a nonexistent workflow yields permanent zero health evidence — the same trap gemini-code-assist's HIGH finding described, in a new form.
3. [LOW — test gap] tests/canary_rollout.bats: the new tests stub gh so any 'run list' returns healthy runs regardless of --repo/--workflow, so neither defect above is detectable by the suite. Consider asserting the repo/workflow arguments the stub receives.
4. [INFO] In the health-signal branch, _baseline_daily still queries the host with run_workflow (the ring-member stub name), which likely yields a zero baseline on the host; behavior then depends on waive_sample_if_no_caller. Worth confirming intended semantics when fixing finding 1.
   Secret scan: run_secret_scanning MCP tool not available in this run; gitleaks CI check passed and the diff (shell/JSON/bats) contains no credential-like content.

CI status

All required checks green at 122eb97: shellcheck, bats (unit tests), CodeQL, SonarCloud quality gate (0 new issues), gitleaks secret scan, agent-shield, holdout-guard, template-drift, gh-aw-compile, validate-agent-profiles. Branch is BEHIND main but MERGEABLE. All 7 bot review threads resolved; no unanswered human questions.

---

Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

Additional tasks

1. Resolve all unresolved review thread comments from other reviewers
2. Ensure all CI checks pass after your changes
3. Rebase on the target branch if behind
4. Do NOT modify files unrelated to the findings above

The review cascade will automatically re-review after new commits are pushed.

[don-petry]

Closing to simplify the canary-release relocation (.github-private → .github). standards/canary-rings.json is about to move to petry-projects/.github, so the idea→initiative pipeline onboarding should be added against the new location. Issue #1008 stays OPEN to track re-targeting. Reviewed diff retained as reference (branch not deleted).