Per-repo caller stub + cross-repo redispatch

[don-petry]

Story

As a fleet-repo maintainer,
I want copy a thin standards/workflows/initiative-planner.yml stub that, on idea:approved, dispatches the central planner for my repo,
so that I get idea→initiative planning without vendoring BMAD frameworks/tooling locally.

Acceptance Criteria

1. A new standards/workflows/initiative-planner.yml (in the public petry-projects/.github repo) triggers on discussion:[labeled], guarded if: github.event.label.name == 'idea:approved', copied verbatim per the org stub convention (mirrors standards/workflows/dev-lead.yml).
2. The stub runs the redispatch path with a target_repo argument, dispatching gh workflow run initiative-planner.yml --repo petry-projects/.github-private -f discussion=<n> -f target_repo=<host>; redispatch.sh gains a TARGET_REPO/-f target_repo arg.
3. The stub documents the required dispatch secret (App token / GH_PAT_WORKFLOWS) and the idea:approved label + Ideas-category prerequisite.
4. The PAT-present guard is retained (a dispatch fired with GITHUB_TOKEN never starts a run — redispatch.sh:17-22).
5. tests/test_initiative_planner_redispatch.bats covers the target_repo argument (re-asserting the regression test feat: implement issue #574 — pr-review: PRs with >300 changed files hard-fail the cascade (gh pr diff 406); define org standard for oversized PRs #606 deleted).

Tasks / Subtasks

• Author standards/workflows/initiative-planner.yml as a thin discussion[labeled] caller stub in petry-projects/.github. (AC: test issue from agent #1)
• Extend redispatch.sh to accept and forward TARGET_REPO; dispatch against .github-private. (AC: Go-live improvements for PR review agent #2)
• Document the required secret, label, and category prerequisite in the stub header. (AC: Add @claude delegation, auto-merge, and rebase handling #3)
• Keep the PAT-present guard. (AC: Optimize review: small-PR and incremental fast paths #4)
• Add a redispatch bats case covering target_repo. (AC: feat: add Copilot engine support via REVIEW_ENGINE toggle #5)

Dev Notes

• Model after standards/workflows/dev-lead.yml (the existing thin caller stub) and standards/workflows/feature-ideation.yml (the existing discussion-triggered stub).
• redispatch.sh:56-58 currently dispatches --repo "$REPO" with -f discussion/-f dry_run; add -f target_repo="$TARGET_REPO" and point --repo at the central .github-private when called from a fleet stub.
• claude-code-action aborts on discussion event contexts, which is exactly why the redispatch bridge exists — the fleet stub must dispatch to workflow_dispatch, never plan inline (see bug(initiative-planner): claude-code-action rejects discussion events — the idea:approved auto-trigger never plans #591/feat: implement issue #591 — bug(initiative-planner): claude-code-action rejects discussion events — the idea:approved auto-trigger never plans #618).
• The deleted-then-restored regression test (test_initiative_planner_redispatch.bats) is re-asserted here on purpose; feat: implement issue #574 — pr-review: PRs with >300 changed files hard-fail the cascade (gh pr diff 406); define org standard for oversized PRs #606 deleted it in the same diff that reverted the feature (see bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618); idea:approved stopped planning #655).

Project Structure Notes

Spans two repos: the stub lands in public petry-projects/.github (standards/workflows/), the redispatch.sh + test changes land in .github-private. Open the stub PR against .github and the script/test PR against .github-private.

References

• standards/workflows/dev-lead.yml (petry-projects/.github)
• standards/workflows/feature-ideation.yml (petry-projects/.github)
• scripts/initiative-planner/redispatch.sh#L56-L58
• tests/test_initiative_planner_redispatch.bats

Likely target surface

• standards/workflows/initiative-planner.yml (new — petry-projects/.github)
• scripts/initiative-planner/redispatch.sh
• tests/test_initiative_planner_redispatch.bats

Story prepared by the BMAD Scrum Master (Bob) for epic #817. Status: ready-for-dev.

[github-actions]

Thanks for the detailed write-up — the acceptance criteria, dev notes, and cross-repo scope are really helpful for anyone picking this up! Before implementation begins, could you clarify whether TARGET_REPO should be validated against an allowlist (e.g., only dispatch to repos within petry-projects) to prevent unauthorized cross-org dispatches, or is the PAT-scope boundary considered sufficient protection?

[don-petry]

Dev-Lead Implementation Plan

Issue: #820 — Per-repo caller stub + cross-repo redispatch

Scope (this repo: .github-private)

Wire the existing target_repo redispatch regression test into CI so AC #5's guard actually runs; the redispatch.sh/test/workflow target_repo plumbing already landed in the merged tree.

Current state assessment

• AC Go-live improvements for PR review agent #2 (redispatch.sh gains TARGET_REPO / -f target_repo): already present (scripts/initiative-planner/redispatch.sh:36,63) and consumed by the central initiative-planner.yml redispatch job.
• AC Optimize review: small-PR and incremental fast paths #4 (PAT-present guard retained): present in the workflow (initiative-planner.yml "Guard — PAT present") and documented in redispatch.sh:17-22.
• AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5 (tests/test_initiative_planner_redispatch.bats covers target_repo): the test exists with both the self/default and fleet-override cases and passes locally (12/12) — but it is not listed in lint.yml's bats job, so it never runs in CI.
• AC test issue from agent #1 / Add @claude delegation, auto-merge, and rebase handling #3 (new standards/workflows/initiative-planner.yml stub + its header docs): live in the public petry-projects/.github repo (there is no standards/ dir here). Out of scope for this repo's PR per the issue's "Project Structure Notes" — they ship in a separate PR against .github.

Implementation Checklist

• Register tests/test_initiative_planner_redispatch.bats in the bats job list in .github/workflows/lint.yml (AGENTS.md requires new test files be added here).

Tests to Write

• No new test needed — tests/test_initiative_planner_redispatch.bats already asserts the target_repo argument (default self-path + fleet host override). This change makes that existing regression guard execute in CI.

Test Command

bats tests/test_initiative_planner_redispatch.bats (and the full scripts/run-bats.sh … list via the bats CI job); lint via bash .dev-lead/scripts/dev-lead-lint.sh.

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• Assessed current .github-private state against all five ACs.
• Registered tests/test_initiative_planner_redispatch.bats in the bats job in .github/workflows/lint.yml so AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5's target_repo regression guard actually runs in CI.
• Verified the full bats suite + repo lint pass.

AC status (this repo)

• AC Go-live improvements for PR review agent #2 (redispatch.sh gains TARGET_REPO / -f target_repo): already satisfied — scripts/initiative-planner/redispatch.sh:36,63, consumed by the central initiative-planner.yml redispatch job (TARGET_REPO env, line 103).
• AC Optimize review: small-PR and incremental fast paths #4 (PAT-present guard retained): satisfied — workflow "Guard — PAT present" step + the loop-prevention rationale documented in redispatch.sh:17-22.
• AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5 (test covers target_repo): test pre-existed with both the default self-path and fleet host-override cases; this PR wires it into CI so the regression guard is live (it was previously never executed by the bats job).
• AC test issue from agent #1 / Add @claude delegation, auto-merge, and rebase handling #3 (new standards/workflows/initiative-planner.yml stub + header docs for the secret/label/Ideas-category prerequisite): these ship in the public petry-projects/.github repo (no standards/ dir exists here). Per the issue's "Project Structure Notes" they belong to a separate PR against .github and are out of scope for this .github-private PR.

Test Results

$ bats tests/test_initiative_planner_redispatch.bats
1..12
ok 1 re-dispatches the planner workflow via workflow_dispatch
ok 2 threads the discussion number and forces dry_run=false
ok 3 targets the correct repo
ok 4 fails when DISCUSSION_NUMBER is unset
ok 5 rejects a non-numeric DISCUSSION_NUMBER without dispatching
ok 6 fails when REPO is unset
ok 7 honors a WORKFLOW_FILE override
ok 8 honors DRY_RUN=1 or DRY_RUN=true
ok 9 passes target_repo defaulting to the dispatch repo (dogfood self path)
ok 10 honors a TARGET_REPO override (fleet host repo)
ok 11 passes GITHUB_REF if it is a branch or tag
ok 12 ignores GITHUB_REF if it is a pull request ref

Full bats job (scripts/run-bats.sh …): 597/597 ok, exit 0
.dev-lead/scripts/dev-lead-lint.sh: all checks passed (shellcheck 67 files, 4 agent profiles)

Files Changed

• .github/workflows/lint.yml: add tests/test_initiative_planner_redispatch.bats to the bats job test list (AGENTS.md requires new test files be registered here).

Notes

• TDD note: Phase 2 was skipped under the documented exception for behavior-preserving CI/config changes — the regression test already exists and passes; this change only makes it execute in CI. No production behavior changed.
• The open reviewer question on the issue (validating TARGET_REPO against a petry-projects allowlist) is a design decision not covered by the ACs; it was intentionally not implemented here to avoid scope creep. Recommend resolving it as a follow-up if cross-org dispatch hardening is desired.
• The redispatch.sh/test/central-workflow target_repo plumbing was already present in the merged tree (the redispatch.sh header even references Per-repo caller stub + cross-repo redispatch #820), so no edits were needed there.

[don-petry]

Reopened: the .github-private-side PR closed this, but the real fleet deliverable — the public caller stub(s) in petry-projects/.github — was not created (dev-lead can't write to the public repo from here). That work is in petry-projects/.github#499. This issue tracks until that PR merges + the channel tag is cut.