[Fleet Monitor] petry-projects/.github-private — .github/workflows/test-dev-lead.yml

[don-petry]

🟡 WARNING: petry-projects/.github-private / .github/workflows/test-dev-lead.yml

Metric	Value
Failure Rate	13.3% (2 / 15 runs)
Status	WARNING
p50 Duration	125s
p95 Duration	236s
Successful Runs	13
Cancelled Runs	0

Workflow: .github/workflows/test-dev-lead.yml

Last updated by Fleet Monitor run on 2026-08-12.
Threshold: failure rate > 10% over the monitored window.

[don-petry]

Dev-Lead Implementation Plan

Issue: #1502 — [Fleet Monitor] petry-projects/.github-private — .github/workflows/test-dev-lead.yml

Root Cause

Both failing runs (31552825778, 31553221287, 2026-08-12) failed in the unit job on the
test Advisory gate: shellcheck passes with an info-level SC1091 finding
(Not following: scripts/lib/reviewer-sources.sh …) on advisory-review-gate.sh's dynamic
source "$_gate_reg_sh". The test invoked shellcheck at default severity, so an info
finding failed the job. Those two runs were PR-CI iterations of #1425 (#1497) before its final
merged commit added --severity=warning — so test_advisory_review_gate.bats is already fixed on
main. The remaining in-scope sibling, test_maintainer_comment_gate.bats, still runs shellcheck
at default severity — a latent recurrence of the same flake class (info-level SC1091 is
CWD/shellcheck-version dependent).

Scope

Standardize the --severity=warning guard across the unit job's shellcheck gate tests so an
info-level finding can never fail the workflow, matching the pattern already used by 3 of 4 siblings.

Implementation Checklist

• tests/dev-lead/unit/test_maintainer_comment_gate.bats — add --severity=warning to the
  shellcheck invocation (line 56), matching test_maintainer_review_thread_gate.bats and
  test_advisory_review_gate.bats.

Tests to Write

• tests/dev-lead/unit/test_shellcheck_severity_consistency.bats — regression guard that fails if
  any shellcheck command invocation in tests/dev-lead/unit/*.bats omits --severity. Fails first
  (red) on the maintainer-comment-gate line, passes after the fix.

Test Command

bats tests/dev-lead/unit/ (full unit job), plus bash .dev-lead/scripts/dev-lead-lint.sh

[don-petry]

Dev-Lead: Implementation Complete

Root Cause (confirmed from run logs)

Runs 31552825778 / 31553221287 (2026-08-12) failed in the unit job, test
Advisory gate: shellcheck passes, on an info-level SC1091 finding
(Not following: scripts/lib/reviewer-sources.sh …) against advisory-review-gate.sh's dynamic
source "$_gate_reg_sh". The test ran shellcheck at default severity, so an info finding
(which is working-directory / shellcheck-version dependent) failed the whole job. Both failures were
PR-CI iterations of #1425 (#1497) before its final merged commit added --severity=warning — so
test_advisory_review_gate.bats is already fixed on main. Reproduced locally: at repo-root CWD,
shellcheck --shell=bash scripts/lib/advisory-review-gate.sh exits 1 on SC1091;
--severity=warning → exit 0.

Plan Execution

• Identified the sole remaining in-scope inconsistency: test_maintainer_comment_gate.bats still
  ran shellcheck at default severity (siblings test_advisory_review_gate.bats and
  test_maintainer_review_thread_gate.bats already use --severity=warning).
• Added a failing regression guard (red), then applied the one-line fix (green).
• Full unit suite + required repo lint pass.

Test Results

$ bats tests/dev-lead/unit/
777 ok, 0 not ok   (full `unit` job)

$ bats tests/dev-lead/unit/test_shellcheck_severity_consistency.bats   # before fix
not ok 1 unit shellcheck invocations pass --severity=warning (no info-level flake — #1502)
# shellcheck invocation without --severity=warning:
# 56:  shellcheck --shell=bash "$GATE"
                                                                        # after fix
ok 1 unit shellcheck invocations pass --severity=warning (no info-level flake — #1502)

$ bash .dev-lead/scripts/dev-lead-lint.sh
[lint] all checks passed

Files Changed

• tests/dev-lead/unit/test_maintainer_comment_gate.bats: add --severity=warning to the
  shellcheck invocation so an info-level finding cannot fail the unit job.
• tests/dev-lead/unit/test_shellcheck_severity_consistency.bats (new): regression guard failing if
  any shellcheck command invocation in tests/dev-lead/unit/*.bats omits --severity=warning,
  preventing this flake class from recurring under a future gate test.

Notes

• Scope is the unit job only (bats tests/dev-lead/unit/). tests/test_reviewer_sources.bats:33
  has the same default-severity pattern but runs in lint.yml's bats job, not test-dev-lead.yml, so
  it is intentionally left untouched (out of this workflow's scope).
• The two observed failures are already resolved on main; this change closes the remaining latent
  recurrence and guards against regressions.