Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToXYZ geometry conversion methods #420

Closed
peterstace opened this issue Oct 17, 2021 · 0 comments
Closed

ToXYZ geometry conversion methods #420

peterstace opened this issue Oct 17, 2021 · 0 comments
Labels
breaking change These will break the API feature New feature or request

Comments

@peterstace
Copy link
Owner

peterstace commented Oct 17, 2021

@albertteoh suggested having geometry conversion methods on the Geometry type that return a bool indicating if the conversion was successful in #399 (comment)

For example, we would add a new method to the Geometry type with signature ToPolygon() (Polygon, bool).

We should also consider whether we want to rename the AsFoo (e.g. AsPolygon) methods to make it clearer that they panic if invoked incorrectly (i.e. without first checking IsFoo). An example of a better name might be MustAsFoo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change These will break the API feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant