Pin pyrsistent to the mayor version to this specific one #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context When using pyredux with pipenv I can't install the latest version of pyrsistent because pyredux requires this exact version. ## Solution This changes that to accept any version that is bigger or equal to the mentioned version but the same major release.
|
Thank you for your fix and comment! You are right and it was about time to fix this. It wasn't a good idea to require a strict version of pyrsistent. I used your fix, to drop python2 (i hope this is not a problem for you) support as well and to do some minor housekeeping. If you want you can have a look at: c32ca55 and comment on my changes. In case of no comment or objection from your side, i will release a new version to pypi soon. |
|
Ah that makes sense. Yeah those changes make sense. Thanks for your quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using pyredux with pipenv I can't install the latest version of pyrsistent because pyredux requires this exact version.
Solution
This changes that to accept any version that is bigger or equal to the mentioned version but the same major release.