Return protocol detected with ir_rx/acquire.py acquire function #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to detect the protocol of an IR command, and found there was no way to properly do it programmatically. So I modified
ir_rx/acquire.py
. TheIR_GET.acquire
function now returns a dict with the keysraw
andprotocol
.raw
returns the marks and spaces list as before, andprotocol
returns the protocol detected bydecode()
, orUnknown
. I also modifiedacquire.py
to still try and detect the protocol used, even ifdisplay
isFalse
. Setting display toTrue
uses print statements and returns the protocol and marks and spaces programmatically, whereasFalse
just doesn't print anything.I also updated the docs for the receiver and transmitter to reflect the changes.
Here is a small test script:
This was only tested on an ESP32-S3, although I doubt further testing on other chip families is needed.
Thank you for this wonderful library, and as this is my first pull request, please let me know if I got something wrong.