Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to your connectionless Cast controller work.
The current setListener path links one shared Binder death recipient each time a listener is installed, but replacing or unregistering the listener does not unlink the old registration. If listener A is replaced by listener B and A later dies, the stale callback can call disconnect() and tear down B's active Cast session.
There is also an ordering issue in normal disconnect(): ChromeCast.disconnect() synchronously calls Channel.close(), which emits the connection event used for onDisconnected() before the socket is closed. Unlinking or clearing the listener before that call can suppress the legitimate disconnect callback.
This patch:
Validation on the branch based directly on your PR head:
The diff is intentionally limited to CastDeviceControllerImpl.java.