Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socksify incompatibility #999

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Mar 8, 2024

  1. Add resolv-replace compatibility test

    While `dalli` doesn't depend on `resolv-replace`, we want to ensure it
    still works if it is required by the host application.
    
    This regression test ensures we don't break compatibility, and adds a
    framework allowing us to test compatibility with other gems in the
    future.
    sambostock committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    610a4b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Fix socksify incompatibility

    Similarly to `resolv-replace`, `sockify` monkey patches
    `TCPSocket#initialize` which causes an error if it is called with
    `connect_timeout:`.
    
    Rather than check only for `resolv-replace`'s specific method, we can
    check if if the method's parameters have changed.
    sambostock committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    916d0fd View commit details
    Browse the repository at this point in the history