Disable HTTP proxy #173
Open
Disable HTTP proxy #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
As shown in Bug #171, the HTTP proxy support is a) only completely broken, and b) makes no sense in this case. The proxy should not be used to contact a device on the local network. And the Hue bridge won't use a proxy to contact the Hue server, so neither should we, to be consistent.
This disables the proxy when making requests to the local bridge and the Hue server.
This fixes the code for me. Without this fix, everything simply fails when a proxy is configured for HTTPS.