Add setNeedsLayout to yoga tree changes. (facebookarchive#1361)

peter-iakovlev · Mar 5, 2019 · babd81b · babd81b
1 parent 96e6a6c
commit babd81b
Show file tree

Hide file tree

Showing 3 changed files with 154 additions and 90 deletions.
diff --git a/Source/ASDisplayNode+Layout.mm b/Source/ASDisplayNode+Layout.mm
@@ -19,6 +19,19 @@
 #import <AsyncDisplayKit/ASNodeController+Beta.h>
 #import <AsyncDisplayKit/ASDisplayNode+Yoga.h>
 
+@interface ASDisplayNode (ASLayoutElementStyleDelegate) <ASLayoutElementStyleDelegate>
+@end
+
+@implementation ASDisplayNode (ASLayoutElementStyleDelegate)
+
+#pragma mark <ASLayoutElementStyleDelegate>
+
+- (void)style:(ASLayoutElementStyle *)style propertyDidChange:(NSString *)propertyName {
+  [self setNeedsLayout];
+}
+
+@end
+
 #pragma mark - ASDisplayNode (ASLayoutElement)
 
 @implementation ASDisplayNode (ASLayoutElement)
@@ -42,8 +55,9 @@ - (ASLayoutElementStyle *)style
 
 - (ASLayoutElementStyle *)_locked_style
 {
+  ASAssertLocked(__instanceLock__);
   if (_style == nil) {
-    _style = [[ASLayoutElementStyle alloc] init];
+    _style = [[ASLayoutElementStyle alloc] initWithDelegate:self];
   }
   return _style;
 }

diff --git a/Source/ASDisplayNode+Yoga.mm b/Source/ASDisplayNode+Yoga.mm
@@ -91,6 +91,7 @@ - (void)_locked_removeYogaChild:(ASDisplayNode *)child
 
   // YGNodeRef removal is done in setParent:
   child.yogaParent = nil;
+  [self setNeedsLayout];
 }
 
 - (void)insertYogaChild:(ASDisplayNode *)child atIndex:(NSUInteger)index
@@ -115,6 +116,7 @@ - (void)_locked_insertYogaChild:(ASDisplayNode *)child atIndex:(NSUInteger)index
 
   // YGNodeRef insertion is done in setParent:
   child.yogaParent = self;
+  [self setNeedsLayout];
 }
 
 #pragma mark - Subclass Hooks