Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helpful error message when unable to enable automerge #345

Merged
merged 3 commits into from
Jun 20, 2022
Merged

feat: add helpful error message when unable to enable automerge #345

merged 3 commits into from
Jun 20, 2022

Conversation

williamboman
Copy link
Contributor

No description provided.

@williamboman williamboman marked this pull request as draft June 17, 2022 13:01
@williamboman williamboman mentioned this pull request Jun 17, 2022
Closed
@williamboman williamboman marked this pull request as ready for review June 17, 2022 13:13
@williamboman
Copy link
Contributor Author

Example workfow that triggers this specific error: https://github.com/williamboman/test-action-automerge/actions/runs/2515705692

@williamboman
Copy link
Contributor Author

And here's the (successful) workflow after enabling automerge with required check: https://github.com/williamboman/test-action-automerge/actions/runs/2515733307

peter-evans
peter-evans approved these changes Jun 20, 2022
View reviewed changes
Copy link
Owner

@peter-evans peter-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me. Appreciate the evidence of your testing. 🏅

My tests in the workflow don't run on pull requests from forks, so I'm just going to merge it to a dev branch to run the tests before merging to main.

@peter-evans peter-evans changed the base branch from main to dev June 20, 2022 00:41
@peter-evans peter-evans merged commit 019ef1b into peter-evans:dev Jun 20, 2022
peter-evans added a commit that referenced this pull request Jun 20, 2022
@peter-evans @williamboman
feat: add helpful error message when unable to enable automerge (#345) (
a5005d8 
#346)

* chore(deps): update @octokit/core

* feat: add helpful error message when unable to enable automerge

* chore: build

Co-authored-by: William Boman <william@redwill.se>
@peter-evans
Copy link
Owner

Released as v2.1.0 / v2

Thank you!

@williamboman williamboman deleted the feat/better-error-logging branch September 1, 2022 13:27
@williamboman williamboman mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-evans peter-evans peter-evans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamboman @peter-evans