Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more 1.8.7 #93

Merged
merged 3 commits into from
Mar 3, 2014
Merged

No more 1.8.7 #93

merged 3 commits into from
Mar 3, 2014

Conversation

blom
Copy link
Collaborator

@blom blom commented Mar 1, 2014

Prompted by #92.

@petems
Copy link
Owner

petems commented Mar 1, 2014

Should we add ruby "1.9.3" to the gemfile too?

@blom
Copy link
Collaborator Author

blom commented Mar 1, 2014

I don't favour it since it would make it hard to use any other version than 1.9.3.

@petems
Copy link
Owner

petems commented Mar 1, 2014

Really? I thought it just worked as a >. Let me check...

@petems
Copy link
Owner

petems commented Mar 1, 2014

gem.required_ruby_version = Gem::Requirement.new(">= 1.9.2") 👍

@blom
Copy link
Collaborator Author

blom commented Mar 2, 2014

Yeah, required_ruby_version in the gemspec is a great idea! I just added it.

blom added a commit that referenced this pull request Mar 3, 2014
@blom
Merge pull request #93 from pearkes/no-more-1.8.7
7a48645 
No more 1.8.7
@blom blom merged commit 7a48645 into master Mar 3, 2014
@blom blom deleted the no-more-1.8.7 branch March 3, 2014 20:34
petems added a commit that referenced this pull request Dec 5, 2017
@petems
Adds ability to disable colors
b7a8fec 
* You can disable colour output for Thor with the environmental variables with `THOR_SHELL=Basic`
* However, this only works for `say ‘hello’, :green`, it won’t apply for custom strings with colour constants in them
* So we add the environmental lookup to our colour code as well!
* Closes #93
petems added a commit that referenced this pull request Dec 5, 2017
@petems
Adds ability to disable colors
d65c208 
* You can disable colour output for Thor with the environmental variables with `THOR_SHELL=Basic`
* However, this only works for `say ‘hello’, :green`, it won’t apply for custom strings with colour constants in them
* So we add the environmental lookup to our colour code as well!
* Closes #93
@petems petems mentioned this pull request Dec 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blom @petems