Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Make json file RFC 4627 valid #70

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Make json file RFC 4627 valid #70

merged 1 commit into from
Sep 26, 2016

Conversation

greglint
Copy link
Contributor

@greglint greglint commented Sep 8, 2016

I noticed the json file has a trailing comma where it shouldn't, and this is hitting my linter.

@ghost
Copy link

ghost commented Sep 8, 2016

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request description cannot be empty (?)
  • Pull request title must not end with a dot (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@ghost
Copy link

ghost commented Sep 8, 2016

This pull request still violates some of our guidelines:

  • Pull request title must not end with a dot (?)

Click here for details.

@greglint greglint changed the title Make json file RFC 4627 valid. Make json file RFC 4627 valid Sep 8, 2016
@ghost
Copy link

ghost commented Sep 8, 2016

Thank you, the title and description now looks good! :bowtie:

@greglint
Copy link
Contributor Author

Hi @petems any chance of getting this merged? I don't think it can break anything, but the Travis CI builds failed for some reason :/

@petems
Copy link
Owner

petems commented Sep 26, 2016

@greglint The tests are failing for some weird reason, will merge this now 👍

@petems petems merged commit 0adf34a into petems:master Sep 26, 2016
@greglint greglint deleted the patch-1 branch September 29, 2016 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants