Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Wrapper #40

Merged
merged 2 commits into from
Feb 10, 2016
Merged

Wrapper #40

merged 2 commits into from
Feb 10, 2016

Conversation

Phil-Friderici
Copy link
Contributor

Since v2.0 it is not possible to use data from hiera. This adds init.pp as wrapper class to allow usage of hiera features like merging through levels.

@Phil-Friderici
Copy link
Contributor Author

Oh, I forgot to update the README. If you like this commit, please let me know and I will add the documentation update.

@petems
Copy link
Owner

petems commented Jan 15, 2016

Hi @Phil-Friderici! Looks cool!

I'm not sure I like hiera only abstract classes in modules though, I prefer that code goes into roles and profiles...

However, you could add the code to the examples/ directory, rename it to hiera.pp as an example of how to do it and add a note to the README about it?

@Phil-Friderici
Copy link
Contributor Author

@petems Sure I'll update README and add an example.

@Phil-Friderici
Copy link
Contributor Author

I have updated the README accordingly. With the wrapper class we now have an alternative upgrade path for v1.0.1 users that I pointed out too.
Examples for hiera usage and wrapper usage are to be find in the examples directory.

With the wrapper class we would be able to upgrade to the upstream version of your module again :)
As the wrapper class is passive it will now allow to choose which way to go. Hope you are able to not dislike it 😏

Thanks and have a nice weekend!

@@ -53,7 +54,7 @@ swap_file::files { 'tmp file swap':
swapfile => '/tmp/swapfile',
cmd => 'fallocate',
}

```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing this was intended

@petems
Copy link
Owner

petems commented Feb 10, 2016

Hey @Phil-Friderici! Sorry it took so long, this looks great! 👍

petems added a commit that referenced this pull request Feb 10, 2016
@petems petems merged commit 5d4f470 into petems:master Feb 10, 2016
@Phil-Friderici
Copy link
Contributor Author

@petems Thanks a lot for reviewing/asking/merging!
Now we can upgrade back to upstream again :)

@petems
Copy link
Owner

petems commented Feb 10, 2016

@Phil-Friderici No problem! Should be able to do a release to the forge tonight, if I dont in a few days remind me! 😄

@Phil-Friderici
Copy link
Contributor Author

@petems our Puppetfile points to your Github source anyway ;)

@Phil-Friderici
Copy link
Contributor Author

@petems do you mind to create a new release tag ?
Wouldn't like to use a specific commit number in our Puppetfiles for modules.

Thanks & have phun
Phil

@petems
Copy link
Owner

petems commented Feb 15, 2016

@Phil-Friderici
Copy link
Contributor Author

THANK YOU, Thank You, thank you ☺️

@Phil-Friderici Phil-Friderici deleted the wrapper branch August 11, 2016 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants