-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Oh, I forgot to update the README. If you like this commit, please let me know and I will add the documentation update. |
Hi @Phil-Friderici! Looks cool! I'm not sure I like hiera only abstract classes in modules though, I prefer that code goes into roles and profiles... However, you could add the code to the examples/ directory, rename it to hiera.pp as an example of how to do it and add a note to the README about it? |
@petems Sure I'll update README and add an example. |
I have updated the README accordingly. With the wrapper class we now have an alternative upgrade path for v1.0.1 users that I pointed out too. With the wrapper class we would be able to upgrade to the upstream version of your module again :) Thanks and have a nice weekend! |
@@ -53,7 +54,7 @@ swap_file::files { 'tmp file swap': | |||
swapfile => '/tmp/swapfile', | |||
cmd => 'fallocate', | |||
} | |||
|
|||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing this was intended
Hey @Phil-Friderici! Sorry it took so long, this looks great! 👍 |
@petems Thanks a lot for reviewing/asking/merging! |
@Phil-Friderici No problem! Should be able to do a release to the forge tonight, if I dont in a few days remind me! 😄 |
@petems our Puppetfile points to your Github source anyway ;) |
@petems do you mind to create a new release tag ? Thanks & have phun |
THANK YOU, Thank You, thank you |
Since v2.0 it is not possible to use data from hiera. This adds init.pp as wrapper class to allow usage of hiera features like merging through levels.