Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hiera to keep looking if value is not found #7

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

traviscosgrave
Copy link
Contributor

This change allows for the configuration of whether or not hiera should keep looking if vault returns nil.

@petems
Copy link
Owner

petems commented May 3, 2018

@traviscosgrave Ah, this looks kinda similar to what I'm doing with #11, is the usecase if you want hiera to continue looking in other backends if it fails to find it in Vault or something?

@traviscosgrave
Copy link
Contributor Author

Yes, that was the idea. Calling context.not_found instead of just returning nil. It was breaking some typing I think, it's be a while now...

@petems petems mentioned this pull request Jun 12, 2018
@davealden davealden merged commit dbd8a79 into petems:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants