Skip to content

Commit

Permalink
use 'to' prefix for method names
Browse files Browse the repository at this point in the history 
tc39/proposal-change-array-by-copy#50
  • Loading branch information
@petamoriken
petamoriken committed Apr 17, 2022
1 parent 88fc043 commit 4c6cafd
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 41 deletions.
16 changes: 8 additions & 8 deletions src/Float16Array.mjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,8 @@ export class Float16Array {
return convertToNumber(float16bitsArray[k]);
}

/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.withAt */
withAt(index, value) {
/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.with */
with(index, value) {
assertFloat16Array(this);
const float16bitsArray = getFloat16BitsArray(this);

Expand Down Expand Up @@ -871,8 +871,8 @@ export class Float16Array {
return this;
}

/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.withReversed */
withReversed() {
/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.toReversed */
toReversed() {
assertFloat16Array(this);
const float16bitsArray = getFloat16BitsArray(this);

Expand Down Expand Up @@ -931,8 +931,8 @@ export class Float16Array {
return this;
}

/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.withSorted */
withSorted(...opts) {
/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.toSorted */
toSorted(...opts) {
assertFloat16Array(this);
const float16bitsArray = getFloat16BitsArray(this);

Expand Down Expand Up @@ -1023,8 +1023,8 @@ export class Float16Array {
return /** @type {any} */ (array);
}

/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.withSpliced */
withSpliced(...opts) {
/** @see https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.toSpliced */
toSpliced(...opts) {
assertFloat16Array(this);
const float16bitsArray = getFloat16BitsArray(this);

Expand Down
66 changes: 33 additions & 33 deletions test/Float16Array.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -826,30 +826,30 @@ describe("Float16Array", () => {
});
});

describe("#withAt()", () => {
it("property `name` is 'withAt'", () => {
assert(Float16Array.prototype.withAt.name === "withAt");
describe("#with()", () => {
it("property `name` is 'with'", () => {
assert(Float16Array.prototype.with.name === "with");
});

it("property `length` is 1", () => {
assert(Float16Array.prototype.withAt.length === 2);
assert(Float16Array.prototype.with.length === 2);
});

it("withAt", () => {
it("with", () => {
const float16_1 = new Float16Array([1, 2, 3]);
const float16_2 = float16_1.withAt(1, 4);
const float16_2 = float16_1.with(1, 4);

assert(float16_1.buffer !== float16_2.buffer);
assert.equalFloat16ArrayValues(float16_1, [1, 2, 3]);
assert.equalFloat16ArrayValues(float16_2, [1, 4, 3]);

const float16_3 = float16_1.withAt(-1, 4);
const float16_3 = float16_1.with(-1, 4);

assert(float16_1.buffer !== float16_3.buffer);
assert.equalFloat16ArrayValues(float16_1, [1, 2, 3]);
assert.equalFloat16ArrayValues(float16_3, [1, 2, 4]);

const float16_4 = float16_1.withAt(0, "aaa");
const float16_4 = float16_1.with(0, "aaa");

assert(float16_1.buffer !== float16_4.buffer);
assert.equalFloat16ArrayValues(float16_1, [1, 2, 3]);
Expand All @@ -861,20 +861,20 @@ describe("Float16Array", () => {

// out of range
assert.throws(() => {
float16.withAt(5, 0);
float16.with(5, 0);
}, RangeError);
assert.throws(() => {
float16.withAt(-5, 0);
float16.with(-5, 0);
}, RangeError);

assert.throws(() => {
float16.withAt(Symbol(), 0);
float16.with(Symbol(), 0);
}, TypeError);

// Safari 13 doesn't have BigInt
if (typeof BigInt !== "undefined") {
assert.throws(() => {
float16.withAt(BigInt(0), 0);
float16.with(BigInt(0), 0);
}, TypeError);
}
});
Expand Down Expand Up @@ -1490,18 +1490,18 @@ describe("Float16Array", () => {
});
});

describe("#withReversed()", () => {
describe("#toReversed()", () => {
it("property `name` is 'reverse'", () => {
assert(Float16Array.prototype.withReversed.name === "withReversed");
assert(Float16Array.prototype.toReversed.name === "toReversed");
});

it("property `length` is 0", () => {
assert(Float16Array.prototype.withReversed.length === 0);
assert(Float16Array.prototype.toReversed.length === 0);
});

it("withReversed", () => {
it("toReversed", () => {
const float16_1 = new Float16Array([1, 2, 3]);
const float16_2 = float16_1.withReversed();
const float16_2 = float16_1.toReversed();

assert(float16_1.buffer !== float16_2.buffer);
assert.equalFloat16ArrayValues(float16_1, [1, 2, 3]);
Expand Down Expand Up @@ -1611,13 +1611,13 @@ describe("Float16Array", () => {
});
});

describe("#withSorted()", () => {
it("property `name` is 'withSorted'", () => {
assert(Float16Array.prototype.withSorted.name === "withSorted");
describe("#toSorted()", () => {
it("property `name` is 'toSorted'", () => {
assert(Float16Array.prototype.toSorted.name === "toSorted");
});

it("property `length` is 0", () => {
assert(Float16Array.prototype.withSorted.length === 0);
assert(Float16Array.prototype.toSorted.length === 0);
});

it("check default compare", () => {
Expand All @@ -1632,7 +1632,7 @@ describe("Float16Array", () => {
Infinity,
-Infinity,
]);
const float16_2 = float16_1.withSorted();
const float16_2 = float16_1.toSorted();

assert(float16_1.buffer !== float16_2.buffer);
assert.equalFloat16ArrayValues(float16_1, [
Expand Down Expand Up @@ -1661,7 +1661,7 @@ describe("Float16Array", () => {

it("check custom compare", () => {
const float16_1 = new Float16Array([1, 2, -1, -2, Infinity, -Infinity]);
const float16_2 = float16_1.withSorted((x, y) => y - x);
const float16_2 = float16_1.toSorted((x, y) => y - x);

assert(float16_1.buffer !== float16_2.buffer);
assert.equalFloat16ArrayValues(float16_1, [
Expand Down Expand Up @@ -1809,43 +1809,43 @@ describe("Float16Array", () => {
});
});

describe("#withSpliced()", () => {
it("property `name` is 'withSpliced'", () => {
assert(Float16Array.prototype.withSpliced.name === "withSpliced");
describe("#toSpliced()", () => {
it("property `name` is 'toSpliced'", () => {
assert(Float16Array.prototype.toSpliced.name === "toSpliced");
});

it("property `length` is 0", () => {
assert(Float16Array.prototype.withSpliced.length === 0);
assert(Float16Array.prototype.toSpliced.length === 0);
});

it("get spliced Array", () => {
const float16_1 = new Float16Array([1, 2, 3]);
const float16_2 = float16_1.withSpliced();
const float16_2 = float16_1.toSpliced();

assert(float16_1.buffer !== float16_2.buffer);
assert.equalFloat16ArrayValues(float16_1, float16_2);

const float16_3 = float16_1.withSpliced(1);
const float16_3 = float16_1.toSpliced(1);

assert(float16_1.buffer !== float16_3.buffer);
assert.equalFloat16ArrayValues(float16_3, [1]);

const float16_4 = float16_1.withSpliced(1, -1);
const float16_4 = float16_1.toSpliced(1, -1);

assert(float16_1.buffer !== float16_4.buffer);
assert.equalFloat16ArrayValues(float16_4, [1, 2, 3]);

const float16_5 = float16_1.withSpliced(1, 10);
const float16_5 = float16_1.toSpliced(1, 10);

assert(float16_1.buffer !== float16_5.buffer);
assert.equalFloat16ArrayValues(float16_5, [1]);

const float16_6 = float16_1.withSpliced(1, 1);
const float16_6 = float16_1.toSpliced(1, 1);

assert(float16_1.buffer !== float16_6.buffer);
assert.equalFloat16ArrayValues(float16_6, [1, 3]);

const float16_7 = float16_1.withSpliced(1, 1, 5, 6);
const float16_7 = float16_1.toSpliced(1, 1, 5, 6);

assert(float16_1.buffer !== float16_7.buffer);
assert.equalFloat16ArrayValues(float16_7, [1, 5, 6, 3]);
Expand Down

0 comments on commit 4c6cafd

Please sign in to comment.