Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitkeep in Tests folders #890

Closed
wants to merge 4 commits into from
Closed

Add .gitkeep in Tests folders #890

wants to merge 4 commits into from

Conversation

soymgomez
Copy link

Q A
Bug fix? no
New feature? yes

When init "Pest" I add some .gitkeep files to the test folders to make sure that these folders are comitted even if they don't have tests inside them.

@owenvoke
Copy link
Member

Personally I don't think this makes sense, as the ExampleTest.php files act as a Gitkeep. 🤷🏻‍♂️

@soymgomez
Copy link
Author

They work until the sample tests are deleted, which is one of the first things we do in the projects.

And if you make a commit with these tests deleted and you have a working pipeline it won't pass because Pest always expects this folder structure.

I think it would be a good idea to leave the .gitkeep folders there in case something happens.

@devajmeireles
Copy link
Member

devajmeireles commented Aug 16, 2023

They work until the sample tests are deleted, which is one of the first things we do in the projects.

And if you make a commit with these tests deleted and you have a working pipeline it won't pass because Pest always expects this folder structure.

I think it would be a good idea to leave the .gitkeep folders there in case something happens.

Thank you for your PR. I think this is unnecessary. Why will I remove files from the Unit folder but keep the Unit folder only with a single file (.gitkeep) if I can control when I have the Unit folder or not by editing phpunit.xml?

For a better organization, I will close this PR. @nunomaduro , will be notified and will be able to restore it if he agrees to keep the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants