Add toNotIncludeSuspiciousCharacters() expectation #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
I recently had to debug an issue that turned out to be caused by a small cyrillic c in the source code.
There are probably lots of other ways to prevent things like this from happening, but I wanted to see if it was possible with an Arch expectation in Pest.
I'm not sure if this feature has a broad enough appeal, or if the spoof check should be implemented on the base Expectation in stead, allowing users to run it on string literals.
If you're interested in this feature, I'll obviously add tests. And since I'm new to Pest I'd appreciate any feedback about better ways to implement this.