Don't warn when a TestRegistry retry recovers - #2983
Open
nohwnd wants to merge 1 commit into
Open
Conversation
The warning was written before the retry ran, so it printed even when the retry recovered and there was nothing for the user to act on. The wrapped operations (Test-Path, New-Item) are idempotent, and when the retry fails the exception propagates and that is the real signal, so the warning is noise either way. Made it a debug message under the Runtime scope. 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke-TestRegistryWithRetrywrites the warning before it retries, so a run printsIO exception during a TestRegistry operation, retrying.even when the retry recovers and there is nothing for the user to act on. The operations it wraps (Test-Path,New-Item) are idempotent, and when the retry fails the exception propagates and that is the real signal. So the warning is noise in both outcomes.Made it a
Write-PesterDebugMessage -Scope Runtimeinstead.Added a test that a recovered retry writes no warning. It fails without the change (5/6) and passes with it (6/6). Whole file green on PS 7.5.5 on macOS.
🤖