Ignore call base class contructor in code coverage #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
force-pushed
the
cc-ignore-basector
branch
from
c3ab7e7
to
156c0ad
Compare
This was referenced Aug 2, 2024
nohwnd
reviewed
Oct 1, 2024
nohwnd
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Calls to base constructors like
base()were discovered never hit by breakpoint or tracer CC. PowerShell only hits scriptblock contents of both constructors.Adding base ctor call to ignore command list.
Issue reported on Discord: https://discord.com/channels/180528040881815552/447476910499299358/1268943815272828998
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.