-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: github actions #23
Conversation
Seems to work well: https://leodog896.github.io/site/ |
I'm having some trouble trying to publish mdbook under |
I just ran |
The issue was on me - I was using an NPM library, serve, which was messing with path resolution. The python dev server works wonderfully. For ease of development, I've separated the tasks to cache Otherwise, the PR is fully ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the GH actions seem ok, I'm just trying to figure out what I should configure before merging it:
- the environment
- the custom domain? I don't see this setting on this repo (unlike for pest-parser.github.io) and not sure if there are some extra DNS records needed to be added (I don't control the domain)
|
This adds GitHub actions support and deployment (fixes #20), with the following:
Currently testing out actions on my own branch before I undraft this PR.
(In the process, had some branch mixups as I'm trying to be on the master branch to test out CI.)