Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: github actions #23

Merged
merged 12 commits into from
Feb 7, 2023
Merged

ci: github actions #23

merged 12 commits into from
Feb 7, 2023

Conversation

LeoDog896
Copy link
Contributor

@LeoDog896 LeoDog896 commented Jan 31, 2023

This adds GitHub actions support and deployment (fixes #20), with the following:

  • pest-parser/book submodule
  • GitHub deployment action
  • Integrates mdbook into taskfile

Currently testing out actions on my own branch before I undraft this PR.
(In the process, had some branch mixups as I'm trying to be on the master branch to test out CI.)

@LeoDog896 LeoDog896 mentioned this pull request Jan 31, 2023
@LeoDog896
Copy link
Contributor Author

Seems to work well: https://leodog896.github.io/site/

@LeoDog896 LeoDog896 marked this pull request as ready for review January 31, 2023 01:56
@LeoDog896
Copy link
Contributor Author

I'm having some trouble trying to publish mdbook under /book. It seems the github pages example wasn't great since I was already under a subdirectory, but going to /book locally shows broken links. How did y'all do it when publishing?

@tomtau
Copy link
Contributor

tomtau commented Feb 1, 2023

I just ran mdbook build inside the book repo's directory and copied the book output directory to https://github.com/pest-parser/pest-parser.github.io/tree/master/book

@LeoDog896
Copy link
Contributor Author

LeoDog896 commented Feb 1, 2023

The issue was on me - I was using an NPM library, serve, which was messing with path resolution. The python dev server works wonderfully.

For ease of development, I've separated the tasks to cache wasm-pack as wasm-pack doesn't do this yet.

Otherwise, the PR is fully ready to go!

@LeoDog896 LeoDog896 requested review from tomtau and removed request for nathanielknight February 3, 2023 01:08
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GH actions seem ok, I'm just trying to figure out what I should configure before merging it:

  1. the environment
  2. the custom domain? I don't see this setting on this repo (unlike for pest-parser.github.io) and not sure if there are some extra DNS records needed to be added (I don't control the domain)

@LeoDog896
Copy link
Contributor Author

  1. CNAME needs to be added (example from pest-parser.github.io)

  2. In Settings -> Pages, change Source to Github Actions
    image

  3. (Your domain is most likely verified, since you use it already. If it's not, follow these instructions): Since pest-parser is an organization, domains are verified on the organization-level. So, in your Organization Settings, go to Pages image, and then the domain owner needs to add the TXT records.

  4. Back in Settings -> Pages, add your domain.

@tomtau tomtau merged commit 701d481 into pest-parser:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive pest-parser.github.io and use github actions instead
2 participants