Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry point for napalm #139

Merged
merged 5 commits into from
May 6, 2024
Merged

Conversation

JoranHonig
Copy link
Contributor

This will allow users to easily include slitherin detectors in their workflows:
#135

Example:
image

How to test

  1. install napalm: pip install napalm-toolbox napalm-slither
  2. run napalm collections list or the command as demonstrated in the picture above

Sidenote

I've not added napalm as a dependency.

If I understand pythons entry-points correctly then the napalm.py module would only be loaded by tools that actually load the entry point. Only napalm would do this, so there is no need to actually require it as a dependency.

This keeps things super clean for people that don't use napalm.

@ndkirillov ndkirillov changed the base branch from master to develop March 7, 2024 07:51
@ndkirillov ndkirillov changed the base branch from develop to master March 7, 2024 07:52
@ndkirillov ndkirillov requested a review from Yhtiyar March 7, 2024 13:01
@ndkirillov ndkirillov assigned ndkirillov and Yhtiyar and unassigned ndkirillov Mar 7, 2024
@olegggatttor
Copy link
Contributor

olegggatttor commented Apr 12, 2024

@JoranHonig Could you please rebase these changes on develop? The flow is usually pr -> develop -> master. Thanks! Then, I will check the integration.

@olegggatttor olegggatttor added the enhancement New feature or request label Apr 12, 2024
@JoranHonig JoranHonig changed the base branch from master to develop April 12, 2024 12:18
@olegggatttor
Copy link
Contributor

olegggatttor commented Apr 12, 2024

Seems like we had sove divergence between develop and master. I pushed master to develop, could you please put now all your changes on top of the latest develop? Cause I see some strange files in your PR. Thanks!

@ndkirillov ndkirillov merged commit 2d386c8 into pessimistic-io:develop May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants